Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2375753002:
Roll buildtools 86f7e41d94..5fd66957f0 (Closed)
|
Created:
4 years, 2 months ago by bungeman-chromium Modified:
4 years, 2 months ago Reviewers:
Dirk Pranke CC:
chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRoll buildtools 86f7e41d94..5fd66957f0
In order to roll GN 65f3a42b24..82dfb24218 (r419871:r421311) and pick up
the following changes:
d51d352 Use WithoutPathExpansion on DictionaryValue in GN.
2793301 Remove reference to base/memory/ref_counted.cc from GN bootstrap.
0730244 Gut gyp_chromium, common.gypi.
This adds buildtools to recursedeps in anticipation of 'recursion' removal.
TBR=dpranke@chromium.org
Committed: https://crrev.com/1835f988aa41f8d9b47128a675b33adc0c06293b
Cr-Commit-Position: refs/heads/master@{#421585}
Patch Set 1 #Patch Set 2 : Add buildtools to recursedeps. #Patch Set 3 : Use the src/ Luke. #Messages
Total messages: 26 (12 generated)
The CQ bit was checked by bungeman@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
On 2016/09/27 22:26:25, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, > http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) When I gclient sync my local version of this, I get the following WARNING: 'src/buildtools/third_party/libc++/trunk' is no longer part of this client. It is recommended that you manually remove it. WARNING: 'src/buildtools/third_party/libc++abi/trunk' is no longer part of this client. It is recommended that you manually remove it. WARNING: 'src/buildtools/clang_format/script' is no longer part of this client. It is recommended that you manually remove it. This must be due to https://codereview.chromium.org/2359723005 because that's the only other thing in this roll. However I'm not entirely sure why yet.
On 2016/09/28 14:12:19, bungeman-chromium wrote: > On 2016/09/27 22:26:25, commit-bot: I haz the power wrote: > > Try jobs failed on following builders: > > linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, > > > http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) > > When I gclient sync my local version of this, I get the following > > WARNING: 'src/buildtools/third_party/libc++/trunk' is no longer part of this > client. It is recommended that you manually remove it. > WARNING: 'src/buildtools/third_party/libc++abi/trunk' is no longer part of this > client. It is recommended that you manually remove it. > WARNING: 'src/buildtools/clang_format/script' is no longer part of this client. > It is recommended that you manually remove it. > > This must be due to https://codereview.chromium.org/2359723005 because that's > the only other thing in this roll. However I'm not entirely sure why yet. I added back the 'recursion = 1' locally (partially reverting https://codereview.chromium.org/2359723005) and this causes the DEPS in buildtools to get sync'ed again. I don't entirely understand gclient when it comes to recursion, and after taking a look at gclient.py I'm now very sure that I don't understand it.
Description was changed from ========== Roll buildtools 86f7e41d94..5fd66957f0 In order to roll GN 65f3a42b24..82dfb24218 (r419871:r421311) and pick up the following changes: d51d352 Use WithoutPathExpansion on DictionaryValue in GN. 2793301 Remove reference to base/memory/ref_counted.cc from GN bootstrap. 0730244 Gut gyp_chromium, common.gypi. TBR=dpranke@chromium.org ========== to ========== Roll buildtools 86f7e41d94..5fd66957f0 In order to roll GN 65f3a42b24..82dfb24218 (r419871:r421311) and pick up the following changes: d51d352 Use WithoutPathExpansion on DictionaryValue in GN. 2793301 Remove reference to base/memory/ref_counted.cc from GN bootstrap. 0730244 Gut gyp_chromium, common.gypi. This adds buildtools to recursedeps in anticipation of 'recursion' removal. TBR=dpranke@chromium.org ==========
The CQ bit was checked by bungeman@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Now with buildtools in recursedeps. I added a comment about what is provided, let me know if it should be changed (or it can just be changed later if needed).
On 2016/09/28 17:22:52, bungeman-chromium wrote: > Now with buildtools in recursedeps. I added a comment about what is provided, > let me know if it should be changed (or it can just be changed later if needed). I tried this (PS2) locally and it worked. For some reason the bot doesn't like it though...
On 2016/09/28 17:35:00, bungeman-chromium wrote: > On 2016/09/28 17:22:52, bungeman-chromium wrote: > > Now with buildtools in recursedeps. I added a comment about what is provided, > > let me know if it should be changed (or it can just be changed later if > needed). > > I tried this (PS2) locally and it worked. For some reason the bot doesn't like > it though... Strange. Okay, go ahead and land the `recursion` fix and let me worry about this. Thanks for trying!
The CQ bit was checked by bungeman@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2016/09/28 17:38:27, Dirk Pranke wrote: > On 2016/09/28 17:35:00, bungeman-chromium wrote: > > On 2016/09/28 17:22:52, bungeman-chromium wrote: > > > Now with buildtools in recursedeps. I added a comment about what is > provided, > > > let me know if it should be changed (or it can just be changed later if > > needed). > > > > I tried this (PS2) locally and it worked. For some reason the bot doesn't like > > it though... > > Strange. Okay, go ahead and land the `recursion` fix and let me worry about > this. Thanks for trying! Turns out I backspaced too much in the copy paste and forgot src/ is needed. It worked locally because I still had the 'recursion' fix hanging around because I ended up on a named branch instead of detatched HEAD (which sync will wipe out instead of rebase).
On 2016/09/28 17:42:00, bungeman-chromium wrote: > Turns out I backspaced too much in the copy paste and forgot src/ is needed. It > worked locally because I still had the 'recursion' fix hanging around because I > ended up on a named branch instead of detatched HEAD (which sync will wipe out > instead of rebase). Ah, right :).
The CQ bit was unchecked by bungeman@chromium.org
The CQ bit was checked by bungeman@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org Link to the patchset: https://codereview.chromium.org/2375753002/#ps40001 (title: "Use the src/ Luke.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Roll buildtools 86f7e41d94..5fd66957f0 In order to roll GN 65f3a42b24..82dfb24218 (r419871:r421311) and pick up the following changes: d51d352 Use WithoutPathExpansion on DictionaryValue in GN. 2793301 Remove reference to base/memory/ref_counted.cc from GN bootstrap. 0730244 Gut gyp_chromium, common.gypi. This adds buildtools to recursedeps in anticipation of 'recursion' removal. TBR=dpranke@chromium.org ========== to ========== Roll buildtools 86f7e41d94..5fd66957f0 In order to roll GN 65f3a42b24..82dfb24218 (r419871:r421311) and pick up the following changes: d51d352 Use WithoutPathExpansion on DictionaryValue in GN. 2793301 Remove reference to base/memory/ref_counted.cc from GN bootstrap. 0730244 Gut gyp_chromium, common.gypi. This adds buildtools to recursedeps in anticipation of 'recursion' removal. TBR=dpranke@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Roll buildtools 86f7e41d94..5fd66957f0 In order to roll GN 65f3a42b24..82dfb24218 (r419871:r421311) and pick up the following changes: d51d352 Use WithoutPathExpansion on DictionaryValue in GN. 2793301 Remove reference to base/memory/ref_counted.cc from GN bootstrap. 0730244 Gut gyp_chromium, common.gypi. This adds buildtools to recursedeps in anticipation of 'recursion' removal. TBR=dpranke@chromium.org ========== to ========== Roll buildtools 86f7e41d94..5fd66957f0 In order to roll GN 65f3a42b24..82dfb24218 (r419871:r421311) and pick up the following changes: d51d352 Use WithoutPathExpansion on DictionaryValue in GN. 2793301 Remove reference to base/memory/ref_counted.cc from GN bootstrap. 0730244 Gut gyp_chromium, common.gypi. This adds buildtools to recursedeps in anticipation of 'recursion' removal. TBR=dpranke@chromium.org Committed: https://crrev.com/1835f988aa41f8d9b47128a675b33adc0c06293b Cr-Commit-Position: refs/heads/master@{#421585} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/1835f988aa41f8d9b47128a675b33adc0c06293b Cr-Commit-Position: refs/heads/master@{#421585} |
