Fix repo url, remove recursion reference in DEPS.

Fix repo url, remove recursion reference in DEPS.

This removes the `recursion=1` entry from the DEPS file (it is no longer
needed, as there are no child DEPS files), and changes `git_url` to
`chromium_url` to be consistent with chromium's DEPS file, so you can
use a single var name for both.

Also, this CL fixes the indentation to be consistent.

R=thakis@chromium.org
BUG=

Committed: 3d2e47bf14e4e67816a53e304dea422fa18f9180

[Nico, 2016-09-23 00:33:50]

On 2016/09/22 23:04:18, Dirk Pranke wrote:

Lgtm

Would have been less eyebrow raising if the commit message had said "buildtools"
somewhere ;-)

[Dirk Pranke, 2016-09-23 00:35:42]

On 2016/09/23 00:33:50, Nico wrote:
> On 2016/09/22 23:04:18, Dirk Pranke wrote:
> 
> Lgtm
> 
> Would have been less eyebrow raising if the commit message had said
"buildtools"
> somewhere ;-)

Yeah, I waffle on this. In a sense it is redundant (what other repo would it be
for?) but 
I often mis that things aren't in one of the bigger repos, too.

[Dirk Pranke, 2016-09-23 23:33:35]

Description was changed from

==========
Fix repo url, remove recursion reference in DEPS.

This removes the `recursion=1` entry from the DEPS file (it is no longer
needed, as there are no child DEPS files), and changes `git_url` to
`chromium_url` to be consistent with chromium's DEPS file, so you can
use a single var name for both.

Also, this CL fixes the indentation to be consistent.

R=thakis@chromium.org
BUG=
==========

to

==========
Fix repo url, remove recursion reference in DEPS.

This removes the `recursion=1` entry from the DEPS file (it is no longer
needed, as there are no child DEPS files), and changes `git_url` to
`chromium_url` to be consistent with chromium's DEPS file, so you can
use a single var name for both.

Also, this CL fixes the indentation to be consistent.

R=thakis@chromium.org
BUG=

Committed: 3d2e47bf14e4e67816a53e304dea422fa18f9180
==========

[Dirk Pranke, 2016-09-23 23:33:36]

Committed patchset #1 (id:1) manually as
3d2e47bf14e4e67816a53e304dea422fa18f9180 (presubmit successful).

[bungeman-chromium, 2016-09-28 15:17:34]

On 2016/09/23 23:33:36, Dirk Pranke wrote:
> Committed patchset #1 (id:1) manually as
> 3d2e47bf14e4e67816a53e304dea422fa18f9180 (presubmit successful).

So this breaks rolling into Chromium, because the DEPS simply aren't being
brought in. I believe this has something to do with the interaction between
'use_relative_paths' and 'recursion'. Note that there are only three DEPS files
in Chromium using 'use_relative_paths' and after this landed, none of them are
actively pulling in deps when 'gclient sync' is run at the top level of
Chromium. It appears that the 'recursion=1' actually means 'do myself' as the
default appears to be '2' (myself and my children). While other DEPS files list
deps, they're actually specifying which of the top level deps their using. I
still haven't figured out all the rules here, but it appears the options are to
add back the 'recursion=1' or to remove the 'use_relative_paths' and promote
these deps out.

[Dirk Pranke, 2016-09-28 16:29:59]

On 2016/09/28 15:17:34, bungeman-chromium wrote:
> On 2016/09/23 23:33:36, Dirk Pranke wrote:
> > Committed patchset #1 (id:1) manually as
> > 3d2e47bf14e4e67816a53e304dea422fa18f9180 (presubmit successful).
> 
> So this breaks rolling into Chromium, because the DEPS simply aren't being
> brought in. I believe this has something to do with the interaction between
> 'use_relative_paths' and 'recursion'. Note that there are only three DEPS
files
> in Chromium using 'use_relative_paths' and after this landed, none of them are
> actively pulling in deps when 'gclient sync' is run at the top level of
> Chromium. It appears that the 'recursion=1' actually means 'do myself' as the
> default appears to be '2' (myself and my children). While other DEPS files
list
> deps, they're actually specifying which of the top level deps their using. I
> still haven't figured out all the rules here, but it appears the options are
to
> add back the 'recursion=1' or to remove the 'use_relative_paths' and promote
> these deps out.

Yeah, 'recursion' is really weird (and we want to get rid of it as a result). 

I think in order to roll buildtools w/o it, you need to add 'buildtools' to the
'recursedeps'
entry in chromium's src/DEPS.