blink: Remove redundant OWNER etc check during presubmit.

third_party/WebKit/PRESUBMIT.py

Index: third_party/WebKit/PRESUBMIT.py
diff --git a/third_party/WebKit/PRESUBMIT.py b/third_party/WebKit/PRESUBMIT.py
index c385157250137e77a50f2f4711ed988f3c5acb39..5d000c7f2b8e16d0d296f766673163a0d817913a 100644
--- a/third_party/WebKit/PRESUBMIT.py
+++ b/third_party/WebKit/PRESUBMIT.py
@@ -13,9 +13,6 @@ import re
 import sys
 
 
-_EXCLUDED_PATHS = ()
-
-
 def _CheckForNonBlinkVariantMojomIncludes(input_api, output_api):
     pattern = input_api.re.compile(r'#include\s+.+\.mojom(.*)\.h[>"]')
     errors = []
@@ -87,13 +84,7 @@ def _CheckWatchlist(input_api, output_api):
 
 def _CommonChecks(input_api, output_api):
     """Checks common to both upload and commit."""
-    # We should figure out what license checks we actually want to use.
-    license_header = r'.*'
-
     results = []
-    results.extend(input_api.canned_checks.PanProjectChecks(
-        input_api, output_api, excluded_paths=_EXCLUDED_PATHS,
-        maxlen=800, license_header=license_header))

[dcheng, 2016/09/27 19:08:47]

Won't this complain if someone modifies a file that doesn't have the standard
Chromium boilerplate?

[Nico, 2016/09/27 19:10:55]

I was wondering that. But I think we currently run owners tests twice, once with
and once without that license_header line, so removing one of the two shouldn't
make things worse than they are today, right?

[Dirk Pranke, 2016/09/27 21:27:25]

In the top-level //PRESUBMIT.py, we exclude //third_party/WebKit (correctly,
because Blink files will have the wrong header). If you also remove things here,
we would default to using the regular Chromium license header, and the checks
would fail. But, since you're also deleting the check, we'll skip the check
completely.

Really, the comment on line 90 still applies: we should figure out which license
checks to do, and do those.

Maybe re-add the comment, link it to a bug to track this, assign to qyearsley@
and cc me?

     results.extend(_CheckForNonBlinkVariantMojomIncludes(input_api, output_api))
     results.extend(_CheckForVersionControlConflicts(input_api, output_api))
     results.extend(_CheckPatchFiles(input_api, output_api))