blink: Remove redundant OWNER etc check during presubmit.

third_party/WebKit/PRESUBMIT.py

 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Top-level presubmit script for Blink.
 
 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
 for more details about the presubmit API built into gcl.
 """
 
 import os
 import re
 import sys
 
 
-_EXCLUDED_PATHS = ()
-
-
 def _CheckForNonBlinkVariantMojomIncludes(input_api, output_api):
     pattern = input_api.re.compile(r'#include\s+.+\.mojom(.*)\.h[>"]')
     errors = []
     for f in input_api.AffectedFiles():
         for line_num, line in f.ChangedContents():
             m = pattern.match(line)
             if m and m.group(1) != '-blink':
                 errors.append('    %s:%d %s' % (
                     f.LocalPath(), line_num, line))
 
@@ skipping 51 matching lines @@
 
         if log_buffer.getvalue():
             errors.append(output_api.PresubmitError(
                 'Cannot parse WATCHLISTS file, please resolve.',
                 log_buffer.getvalue().splitlines()))
     return errors
 
 
 def _CommonChecks(input_api, output_api):
     """Checks common to both upload and commit."""
-    # We should figure out what license checks we actually want to use.
-    license_header = r'.*'
-
     results = []
-    results.extend(input_api.canned_checks.PanProjectChecks(
-        input_api, output_api, excluded_paths=_EXCLUDED_PATHS,
-        maxlen=800, license_header=license_header))

[dcheng, 2016/09/27 19:08:47]

Won't this complain if someone modifies a file that doesn't have the standard
Chromium boilerplate?

[Nico, 2016/09/27 19:10:55]

I was wondering that. But I think we currently run owners tests twice, once with
and once without that license_header line, so removing one of the two shouldn't
make things worse than they are today, right?

[Dirk Pranke, 2016/09/27 21:27:25]

In the top-level //PRESUBMIT.py, we exclude //third_party/WebKit (correctly,
because Blink files will have the wrong header). If you also remove things here,
we would default to using the regular Chromium license header, and the checks
would fail. But, since you're also deleting the check, we'll skip the check
completely.

Really, the comment on line 90 still applies: we should figure out which license
checks to do, and do those.

Maybe re-add the comment, link it to a bug to track this, assign to qyearsley@
and cc me?

     results.extend(_CheckForNonBlinkVariantMojomIncludes(input_api, output_api))
     results.extend(_CheckForVersionControlConflicts(input_api, output_api))
     results.extend(_CheckPatchFiles(input_api, output_api))
     results.extend(_CheckTestExpectations(input_api, output_api))
     results.extend(_CheckChromiumPlatformMacros(input_api, output_api))
     results.extend(_CheckWatchlist(input_api, output_api))
     results.extend(_CheckFilePermissions(input_api, output_api))
     return results
 
 
@@ skipping 264 matching lines @@
     new_description = description
     new_description += '\nCQ_INCLUDE_TRYBOTS=%s' % ';'.join(bots)
     results.append(output_api.PresubmitNotifyResult(
         'Automatically added slimming-paint-v2 tests to run on CQ due to '
         'changes in paint or compositing directories.'))
 
     if new_description != description:
         rietveld_obj.update_description(issue, new_description)
 
     return results