Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 23757029: Merge 157392 "Avoid collapsing anonymous block children already ..." (Closed)

Created:
7 years, 3 months ago by leviw_travelin_and_unemployed
Modified:
7 years, 3 months ago
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering
Visibility:
Public.

Description

Merge 157392 "Avoid collapsing anonymous block children already ..." > Avoid collapsing anonymous block children already being destroyed > > When normalizing a block with anonymous blocks for first-letter, > before content, and contained text, a collapsing anonymous block > cascade is triggered that attempts to collapse the contained > text's anonymous block within its destruction method. To avoid > this, adding logic to bail early if we're already destroying > the child anonymous block we're trying to collapse. > > While in the function, doing a little cleanup to make it more > obvious that it only operates on RenderBlocks, not RenderBoxes, > and updating some of the comments to hopefully be more useful. > > BUG=282088 > > Review URL: https://chromiumcodereview.appspot.com/23463021 TBR=leviw@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157549

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -12 lines) Patch
A + LayoutTests/fast/css-generated-content/normalize-with-first-letter-and-before-content-crash.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/css-generated-content/normalize-with-first-letter-and-before-content-crash-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/core/rendering/RenderBlock.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderBlock.cpp View 3 chunks +19 lines, -13 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
leviw_travelin_and_unemployed
7 years, 3 months ago (2013-09-10 21:06:06 UTC) #1
leviw_travelin_and_unemployed
7 years, 3 months ago (2013-09-10 21:06:48 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r157549.

Powered by Google App Engine
This is Rietveld 408576698