Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 2375653003: DevTools: add an API for extension-supplied trace providers (Closed)

Created:
4 years, 2 months ago by caseq
Modified:
4 years, 2 months ago
Reviewers:
alph
CC:
chromium-reviews, extensions-reviews_chromium.org, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, chromium-apps-reviews_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: add an API for extension-supplied trace providers Original CL by: Michael Gao < fgao@google.com >, see https://codereview.chromium.org/2128133002/ for history/details. BUG=620066 Committed: https://crrev.com/22a2fc81054f4a32279ba3bd1ce6feab5e06c70d Cr-Commit-Position: refs/heads/master@{#421433}

Patch Set 1 #

Total comments: 1

Patch Set 2 : review comments addressed #

Messages

Total messages: 19 (12 generated)
caseq
4 years, 2 months ago (2016-09-27 21:54:54 UTC) #7
alph
lgtm https://codereview.chromium.org/2375653003/diff/1/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionAPI.js File third_party/WebKit/Source/devtools/front_end/extensions/ExtensionAPI.js (right): https://codereview.chromium.org/2375653003/diff/1/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionAPI.js#newcode577 third_party/WebKit/Source/devtools/front_end/extensions/ExtensionAPI.js:577: function TraceProvider(id) nit: annotate
4 years, 2 months ago (2016-09-27 23:11:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2375653003/20001
4 years, 2 months ago (2016-09-27 23:53:08 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/37863)
4 years, 2 months ago (2016-09-28 02:02:18 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2375653003/20001
4 years, 2 months ago (2016-09-28 02:24:42 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-28 03:08:47 UTC) #17
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 03:11:48 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/22a2fc81054f4a32279ba3bd1ce6feab5e06c70d
Cr-Commit-Position: refs/heads/master@{#421433}

Powered by Google App Engine
This is Rietveld 408576698