Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(719)

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js

Issue 2375653003: DevTools: add an API for extension-supplied trace providers (Closed)
Patch Set: review comments addressed Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/externs.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js
diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js
index eeb468e9e0eee65797346da267bfbfab2ccfdd58..bff0aa5a0d0a8b5221d8ed62240a18f183e42f9e 100644
--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js
+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js
@@ -29,6 +29,8 @@ WebInspector.TimelineController.prototype = {
*/
startRecording: function(captureCauses, enableJSSampling, captureMemory, capturePictures, captureFilmStrip)
{
+ this._extensionTraceProviders = WebInspector.extensionServer.traceProviders().slice();
+
function disabledByDefault(category)
{
return "disabled-by-default-" + category;
@@ -66,6 +68,9 @@ WebInspector.TimelineController.prototype = {
if (captureFilmStrip)
categoriesArray.push(disabledByDefault("devtools.screenshot"));
+ for (var traceProvider of this._extensionTraceProviders)
+ traceProvider.start();
+
var categories = categoriesArray.join(",");
this._startRecordingWithCategories(categories, enableJSSampling);
},
@@ -80,6 +85,9 @@ WebInspector.TimelineController.prototype = {
Promise.all(tracingStoppedPromises).then(() => this._allSourcesFinished());
this._delegate.loadingStarted();
+
+ for (var traceProvider of this._extensionTraceProviders)
+ traceProvider.stop();
},
/**
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/externs.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698