Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2487)

Unified Diff: chrome/browser/extensions/extension_view_host.cc

Issue 2375623003: Revert of Allow top-level navigation in extension pop-ups if it only triggers a download. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_view_host.cc
diff --git a/chrome/browser/extensions/extension_view_host.cc b/chrome/browser/extensions/extension_view_host.cc
index ea544c71fd365928d990663cee02277bf889e04e..615e13cd8abf6e28db278d05fbf2ccec1f60db9e 100644
--- a/chrome/browser/extensions/extension_view_host.cc
+++ b/chrome/browser/extensions/extension_view_host.cc
@@ -165,14 +165,6 @@
}
}
-bool ExtensionViewHost::ShouldTransferNavigation(
- bool is_main_frame_navigation) {
- // Block navigations that cause main frame of an extension pop-up (or
- // background page) to navigate to non-extension content (i.e. to web
- // content).
- return !is_main_frame_navigation;
-}
-
bool ExtensionViewHost::PreHandleKeyboardEvent(
WebContents* source,
const NativeWebKeyboardEvent& event,
« no previous file with comments | « chrome/browser/extensions/extension_view_host.h ('k') | chrome/browser/extensions/process_management_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698