chrome/browser/extensions/extension_view_host.h - Issue 2375623003: Revert of Allow top-level navigation in extension pop-ups if it only triggers a download.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_view_host.h

Issue 2375623003: Revert of Allow top-level navigation in extension pop-ups if it only triggers a download. (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_view_host.h

diff --git a/chrome/browser/extensions/extension_view_host.h b/chrome/browser/extensions/extension_view_host.h

index 70263c8ca1f4938aa872d30062f062064914b21d..d61c96f1d455a346007512a9920fe180519f6ff8 100644

--- a/chrome/browser/extensions/extension_view_host.h

+++ b/chrome/browser/extensions/extension_view_host.h

@@ -67,7 +67,6 @@

content::WebContents* OpenURLFromTab(

content::WebContents* source,

const content::OpenURLParams& params) override;

- bool ShouldTransferNavigation(bool is_main_frame_navigation) override;

bool PreHandleKeyboardEvent(content::WebContents* source,

const content::NativeWebKeyboardEvent& event,

bool* is_keyboard_shortcut) override;