GN: match shell behavior for cc and cxx in is_clang.py

GN: match shell behavior for cc and cxx in is_clang.py

Interprets cc/cxx as part of the shell command rather than literal
arguments. This matches the behavior of shell invocations from ninja.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2375573002

Committed: https://skia.googlesource.com/skia/+/53c7bbfaaf80983c14f2f4f25be0786158d50236

[csmartdalton, 2016-09-27 02:38:47]

Description was changed from

==========
GN: make is_clang.py compatible with compiler prefix commands

Interprets cc/cxx as part of the shell command rather than a literal
argument. This makes it compatible with compiler prefix commands like
ccache, goma, distcc, etc.

BUG=skia:
==========

to

==========
GN: make is_clang.py compatible with compiler prefix commands

Interprets cc/cxx as part of the shell command rather than a literal
argument. This makes it compatible with compiler prefix commands like
ccache, goma, distcc, etc.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2375573002
==========

[csmartdalton, 2016-09-27 02:39:54]

csmartdalton@google.com changed reviewers:
+ mtklein@google.com

[mtklein, 2016-09-27 02:41:10]

Have you tried cc_wrapper?

[csmartdalton, 2016-09-27 02:52:21]

Ok, cc_wrapper looks like the right solution for prefixes (nice!). However, I
also like to do the following with goma:

cc="clang -fcolor-diagnostics"

Otherwise I don't get colored output. Is there a preferred alternate method for
accomplishing this?

Regardless, I think it's pretty standard for cc and cxx to be substituted into
the shell command rather than treated as a literal arguments, so it feels right
to me to treat them like that here as well.

[mtklein, 2016-09-27 02:52:49]

On 2016/09/27 02:52:21, csmartdalton wrote:
> Ok, cc_wrapper looks like the right solution for prefixes (nice!). However, I
> also like to do the following with goma:
> 
> cc="clang -fcolor-diagnostics"
> 
> Otherwise I don't get colored output. Is there a preferred alternate method
for
> accomplishing this?
> 
> Regardless, I think it's pretty standard for cc and cxx to be substituted into
> the shell command rather than treated as a literal arguments, so it feels
right
> to me to treat them like that here as well.

extra_cflags

[csmartdalton, 2016-09-27 03:01:27]

On 2016/09/27 02:52:49, mtklein wrote:
> On 2016/09/27 02:52:21, csmartdalton wrote:
> > Ok, cc_wrapper looks like the right solution for prefixes (nice!). However,
I
> > also like to do the following with goma:
> > 
> > cc="clang -fcolor-diagnostics"
> > 
> > Otherwise I don't get colored output. Is there a preferred alternate method
> for
> > accomplishing this?
> > 
> > Regardless, I think it's pretty standard for cc and cxx to be substituted
into
> > the shell command rather than treated as a literal arguments, so it feels
> right
> > to me to treat them like that here as well.
> 
> extra_cflags

Awesome.

I'm out of ideas to try and justify this

[csmartdalton, 2016-09-27 03:01:53]

Description was changed from

==========
GN: make is_clang.py compatible with compiler prefix commands

Interprets cc/cxx as part of the shell command rather than a literal
argument. This makes it compatible with compiler prefix commands like
ccache, goma, distcc, etc.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2375573002
==========

to

==========
GN: make is_clang.py compatible with compiler prefix commands

Interprets cc/cxx as part of the shell command rather than a literal
argument. This makes it compatible with compiler prefix commands like
ccache, goma, distcc, etc.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2375573002
==========

[mtklein, 2016-09-27 11:38:28]

That all said, lgtm.

[csmartdalton, 2016-09-27 15:53:43]

Description was changed from

==========
GN: make is_clang.py compatible with compiler prefix commands

Interprets cc/cxx as part of the shell command rather than a literal
argument. This makes it compatible with compiler prefix commands like
ccache, goma, distcc, etc.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2375573002
==========

to

==========
GN: match shell behavior for cc and cxx in is_clang.py

Interprets cc/cxx as part of the shell command rather than literal
arguments. This matches the behavior of shell invocations from ninja.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2375573002
==========

[csmartdalton, 2016-09-27 15:58:49]

The CQ bit was checked by csmartdalton@google.com

[commit-bot: I haz the power, 2016-09-27 15:59:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 16:29:26]

Description was changed from

==========
GN: match shell behavior for cc and cxx in is_clang.py

Interprets cc/cxx as part of the shell command rather than literal
arguments. This matches the behavior of shell invocations from ninja.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2375573002
==========

to

==========
GN: match shell behavior for cc and cxx in is_clang.py

Interprets cc/cxx as part of the shell command rather than literal
arguments. This matches the behavior of shell invocations from ninja.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2375573002

Committed:
https://skia.googlesource.com/skia/+/53c7bbfaaf80983c14f2f4f25be0786158d50236
==========

[commit-bot: I haz the power, 2016-09-27 16:29:27]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/53c7bbfaaf80983c14f2f4f25be0786158d50236