Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Unified Diff: gn/is_clang.py

Issue 2375573002: GN: match shell behavior for cc and cxx in is_clang.py (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gn/is_clang.py
diff --git a/gn/is_clang.py b/gn/is_clang.py
index 99173a004c521f8073f4c6faf2cb52e89120967f..a63111c7a97284fb9cefeea21fb768bee88037b6 100755
--- a/gn/is_clang.py
+++ b/gn/is_clang.py
@@ -9,8 +9,8 @@ import subprocess
import sys
cc,cxx = sys.argv[1:3]
-if ('clang' in subprocess.check_output([cc, '--version']) and
- 'clang' in subprocess.check_output([cxx, '--version'])):
+if ('clang' in subprocess.check_output('%s --version' % cc, shell=True) and
+ 'clang' in subprocess.check_output('%s --version' % cxx, shell=True)):
print 'true'
else:
print 'false'
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698