ImageCapture: wire |colorTemperature| set/get for Linux/Cros

ImageCapture: wire |colorTemperature| set/get for Linux/Cros

This CL adds getting/setting colorTemperature from
idl to Linux/CrOs implementation.

File image_capture.mojom photo capabilities/settings
is reordered to follow the Spec definition order and
the idl. (The only added fields are called
|color_temperature|).

BUG=650675
TEST=by hand using [1] on a Linux + Logitech C920.
Improved LayoutTests.

[1] https://rawgit.com/Miguelao/demos/master/imagecapture.html

Committed: https://crrev.com/dd1e2163fdc66f0204c4de304e2b0bcffceec31b
Cr-Commit-Position: refs/heads/master@{#421388}

[mcasas, 2016-09-27 20:45:13]

Description was changed from

==========
ImageCapture: wire |colorTemperature| set/get for Linux/Cros

wip

BUG=650675
==========

to

==========
ImageCapture: wire |colorTemperature| set/get for Linux/Cros

This CL adds getting/setting colorTemperature from
idl to Linux/CrOs implementation.

File image_capture.mojom photo capabilities/settings
is reordered to follow the Spec definition order and
the idl. (The only added fields are called 
|color_temperature|).

BUG=650675
TEST=by hand using [1] on a Linux + Logitech C920.
Improved LayoutTests.

[1] https://rawgit.com/Miguelao/demos/master/imagecapture.html
==========

[mcasas, 2016-09-27 21:30:16]

mcasas@chromium.org changed reviewers:
+ chfremer@chromium.org, tsepez@chromium.org

[mcasas, 2016-09-27 21:30:17]

tsepez@: RS image_capture.mojom plz

chfremer@ PTAL

[Tom Sepez, 2016-09-27 21:37:22]

RS LGTM on mojom

[chfremer, 2016-09-27 21:46:40]

lgtm % comments

https://codereview.chromium.org/2375543004/diff/20001/media/capture/video/lin...
File media/capture/video/linux/v4l2_capture_delegate.cc (right):

https://codereview.chromium.org/2375543004/diff/20001/media/capture/video/lin...
media/capture/video/linux/v4l2_capture_delegate.cc:406:
color_temperature_current.value;
nit: I am somewhat surprised that something called a "Range" as part of a set of
"Capabilities" contains a "current" value.

https://codereview.chromium.org/2375543004/diff/20001/media/capture/video/lin...
media/capture/video/linux/v4l2_capture_delegate.cc:443: // Color temperature can
only be applied if Auto White Balance is off.
If auto white balance is on, we just ignore the request as opposed to notifying
the client that there was an issue. Is that intended?

[mcasas, 2016-09-27 21:57:38]

https://codereview.chromium.org/2375543004/diff/20001/media/capture/video/lin...
File media/capture/video/linux/v4l2_capture_delegate.cc (right):

https://codereview.chromium.org/2375543004/diff/20001/media/capture/video/lin...
media/capture/video/linux/v4l2_capture_delegate.cc:406:
color_temperature_current.value;
On 2016/09/27 21:46:39, chfremer wrote:
> nit: I am somewhat surprised that something called a "Range" as part of a set
of
> "Capabilities" contains a "current" value. 

Yeah heh, it comes straight from the W3C Spec:
https://www.w3.org/TR/image-capture/#MediaSettingsRange
but you are more than welcome (in fact, encouraged!)
to file a bug against the spec for that.

https://codereview.chromium.org/2375543004/diff/20001/media/capture/video/lin...
media/capture/video/linux/v4l2_capture_delegate.cc:443: // Color temperature can
only be applied if Auto White Balance is off.
On 2016/09/27 21:46:39, chfremer wrote:
> If auto white balance is on, we just ignore the request as opposed to
notifying
> the client that there was an issue. Is that intended?

Yeah, hmm, the Spec says so: " This field 
is only signficant if whiteBalanceMode is manual." [1] 
But I was just thinking this should be exercised
in some kind of unittests/content_browsertests,
so I'll do this next.  It's hard to encode
this in tests since it depends partially on
the hardware capabilities :(

[1] https://www.w3.org/TR/image-capture/#dom-photosettings-colortemperature

[mcasas, 2016-09-27 21:57:50]

Patchset #1 (id:1) has been deleted

[mcasas, 2016-09-27 21:57:56]

The CQ bit was checked by mcasas@chromium.org

[commit-bot: I haz the power, 2016-09-27 21:58:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 23:48:25]

Description was changed from

==========
ImageCapture: wire |colorTemperature| set/get for Linux/Cros

This CL adds getting/setting colorTemperature from
idl to Linux/CrOs implementation.

File image_capture.mojom photo capabilities/settings
is reordered to follow the Spec definition order and
the idl. (The only added fields are called 
|color_temperature|).

BUG=650675
TEST=by hand using [1] on a Linux + Logitech C920.
Improved LayoutTests.

[1] https://rawgit.com/Miguelao/demos/master/imagecapture.html
==========

to

==========
ImageCapture: wire |colorTemperature| set/get for Linux/Cros

This CL adds getting/setting colorTemperature from
idl to Linux/CrOs implementation.

File image_capture.mojom photo capabilities/settings
is reordered to follow the Spec definition order and
the idl. (The only added fields are called 
|color_temperature|).

BUG=650675
TEST=by hand using [1] on a Linux + Logitech C920.
Improved LayoutTests.

[1] https://rawgit.com/Miguelao/demos/master/imagecapture.html
==========

[commit-bot: I haz the power, 2016-09-27 23:48:26]

Committed patchset #1 (id:20001)

[commit-bot: I haz the power, 2016-09-27 23:51:50]

Description was changed from

==========
ImageCapture: wire |colorTemperature| set/get for Linux/Cros

This CL adds getting/setting colorTemperature from
idl to Linux/CrOs implementation.

File image_capture.mojom photo capabilities/settings
is reordered to follow the Spec definition order and
the idl. (The only added fields are called 
|color_temperature|).

BUG=650675
TEST=by hand using [1] on a Linux + Logitech C920.
Improved LayoutTests.

[1] https://rawgit.com/Miguelao/demos/master/imagecapture.html
==========

to

==========
ImageCapture: wire |colorTemperature| set/get for Linux/Cros

This CL adds getting/setting colorTemperature from
idl to Linux/CrOs implementation.

File image_capture.mojom photo capabilities/settings
is reordered to follow the Spec definition order and
the idl. (The only added fields are called
|color_temperature|).

BUG=650675
TEST=by hand using [1] on a Linux + Logitech C920.
Improved LayoutTests.

[1] https://rawgit.com/Miguelao/demos/master/imagecapture.html

Committed: https://crrev.com/dd1e2163fdc66f0204c4de304e2b0bcffceec31b
Cr-Commit-Position: refs/heads/master@{#421388}
==========

[commit-bot: I haz the power, 2016-09-27 23:51:51]

Patchset 1 (id:??) landed as
https://crrev.com/dd1e2163fdc66f0204c4de304e2b0bcffceec31b
Cr-Commit-Position: refs/heads/master@{#421388}