ImageCapture: wire |colorTemperature| set/get for Linux/Cros

media/capture/video/linux/v4l2_capture_delegate.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/capture/video/linux/v4l2_capture_delegate.h"
 
 #include <poll.h>
 #include <sys/fcntl.h>
 #include <sys/ioctl.h>
 #include <sys/mman.h>
@@ skipping 368 matching lines @@
   photo_capabilities->white_balance_mode = mojom::MeteringMode::NONE;
   v4l2_control white_balance_current = {};
   white_balance_current.id = V4L2_CID_AUTO_WHITE_BALANCE;
   if (HANDLE_EINTR(ioctl(device_fd_.get(), VIDIOC_G_CTRL,
                          &white_balance_current)) >= 0) {
     photo_capabilities->white_balance_mode =
         white_balance_current.value ? mojom::MeteringMode::CONTINUOUS
                                     : mojom::MeteringMode::MANUAL;
   }
 
+  photo_capabilities->color_temperature = mojom::Range::New();
+  v4l2_queryctrl color_temperature_range = {};
+  color_temperature_range.id = V4L2_CID_WHITE_BALANCE_TEMPERATURE;
+  color_temperature_range.type = V4L2_CTRL_TYPE_INTEGER;
+  if (HANDLE_EINTR(ioctl(device_fd_.get(), VIDIOC_QUERYCTRL,
+                         &color_temperature_range)) >= 0) {
+    photo_capabilities->color_temperature->max =
+        color_temperature_range.maximum;
+    photo_capabilities->color_temperature->min =
+        color_temperature_range.minimum;
+  }
+
+  v4l2_control color_temperature_current = {};
+  color_temperature_current.id = V4L2_CID_WHITE_BALANCE_TEMPERATURE;
+  if (HANDLE_EINTR(ioctl(device_fd_.get(), VIDIOC_G_CTRL,
+                         &color_temperature_current)) >= 0) {
+    photo_capabilities->color_temperature->current =
+        color_temperature_current.value;

[chfremer, 2016/09/27 21:46:39]

nit: I am somewhat surprised that something called a "Range" as part of a set of
"Capabilities" contains a "current" value. 

[mcasas, 2016/09/27 21:57:38]

Yeah heh, it comes straight from the W3C Spec:
https://www.w3.org/TR/image-capture/#MediaSettingsRange
but you are more than welcome (in fact, encouraged!)
to file a bug against the spec for that.

+  }
+
   photo_capabilities->iso = mojom::Range::New();
   photo_capabilities->height = mojom::Range::New();
   photo_capabilities->width = mojom::Range::New();
   photo_capabilities->exposure_compensation = mojom::Range::New();
   photo_capabilities->fill_light_mode = mojom::FillLightMode::NONE;
   photo_capabilities->red_eye_reduction = false;
   callback.Run(std::move(photo_capabilities));
 }
 
 void V4L2CaptureDelegate::SetPhotoOptions(
     mojom::PhotoSettingsPtr settings,
     VideoCaptureDevice::SetPhotoOptionsCallback callback) {
   DCHECK(v4l2_task_runner_->BelongsToCurrentThread());
   if (!device_fd_.is_valid() || !is_capturing_)
     return;
 
   if (settings->has_zoom) {
     v4l2_control zoom_current = {};
     zoom_current.id = V4L2_CID_ZOOM_ABSOLUTE;
     zoom_current.value = settings->zoom / kZoomMultiplier;
     if (HANDLE_EINTR(ioctl(device_fd_.get(), VIDIOC_S_CTRL, &zoom_current)) < 0)
       DPLOG(ERROR) << "setting zoom to " << settings->zoom / kZoomMultiplier;
   }
+
+  if (settings->has_white_balance_mode &&
+      (settings->white_balance_mode == mojom::MeteringMode::CONTINUOUS ||
+       settings->white_balance_mode == mojom::MeteringMode::MANUAL)) {
+    v4l2_control white_balance_set = {};
+    white_balance_set.id = V4L2_CID_AUTO_WHITE_BALANCE;
+    white_balance_set.value =
+        settings->white_balance_mode == mojom::MeteringMode::CONTINUOUS;
+    HANDLE_EINTR(ioctl(device_fd_.get(), VIDIOC_S_CTRL, &white_balance_set));
+  }
+
+  // Color temperature can only be applied if Auto White Balance is off.

[chfremer, 2016/09/27 21:46:39]

If auto white balance is on, we just ignore the request as opposed to notifying
the client that there was an issue. Is that intended?

[mcasas, 2016/09/27 21:57:38]

Yeah, hmm, the Spec says so: " This field 
is only signficant if whiteBalanceMode is manual." [1] 
But I was just thinking this should be exercised
in some kind of unittests/content_browsertests,
so I'll do this next.  It's hard to encode
this in tests since it depends partially on
the hardware capabilities :(

[1] https://www.w3.org/TR/image-capture/#dom-photosettings-colortemperature

+  if (settings->has_color_temperature) {
+    v4l2_control auto_white_balance_current = {};
+    auto_white_balance_current.id = V4L2_CID_AUTO_WHITE_BALANCE;
+    const int result = HANDLE_EINTR(
+        ioctl(device_fd_.get(), VIDIOC_G_CTRL, &auto_white_balance_current));
+    if (result >= 0 && !auto_white_balance_current.value) {
+      v4l2_control set_temperature = {};
+      set_temperature.id = V4L2_CID_WHITE_BALANCE_TEMPERATURE;
+      set_temperature.value = settings->color_temperature;
+      HANDLE_EINTR(ioctl(device_fd_.get(), VIDIOC_S_CTRL, &set_temperature));
+    }
+  }
+
   callback.Run(true);
 }
 
 void V4L2CaptureDelegate::SetRotation(int rotation) {
   DCHECK(v4l2_task_runner_->BelongsToCurrentThread());
   DCHECK(rotation >= 0 && rotation < 360 && rotation % 90 == 0);
   rotation_ = rotation;
 }
 
 V4L2CaptureDelegate::~V4L2CaptureDelegate() {}
@@ skipping 118 matching lines @@
     DLOG(ERROR) << "Error mmap()ing a V4L2 buffer into userspace";
     return false;
   }
   start_ = static_cast<uint8_t*>(start);
   length_ = buffer.length;
   payload_size_ = 0;
   return true;
 }
 
 }  // namespace media