Remove timing dependency to document onload in dialog-close-event.html

Remove timing dependency to document onload in dialog-close-event.html

A follow-up of https://codereview.chromium.org/2355743005.

Previously, the layout test fast/dom/HTMLDialogElement/dialog-close-event.html
expected dialog's close event is not called before test completed, because the
dialog's close event should be called asynchronously.

However, if the timing of document's onload event is changed (e.g. by
Issue 624697), the dialog's close event might be called before document's
onload event, i.e. before test completes.

This CL makes the test to wait until two dialog's close events are called,
no matter when document's onload is called.

BUG=380087, 624697
Committed: https://crrev.com/4bc45550a35c63d7e400733e9bdf00114aa13e10
Cr-Commit-Position: refs/heads/master@{#422033}

[hiroshige, 2016-09-29 09:54:49]

Description was changed from

==========
Remove timing dependency to document onload in dialog-close-event.html

BUG=380087
==========

to

==========
Remove timing dependency to document onload in dialog-close-event.html

Previously, the layout test fast/dom/HTMLDialogElement/dialog-close-event.html
expected dialog's close event is not called before test completed, because the
dialog's close event should be called asynchronously.

However, if the timing of document's onload event is changed (e.g. by
Issue 624697), the dialog's close event might be called before document's
onload event, i.e. before test completes.

This CL makes the test to check two dialog's close events explicitly, no matter
when document's onload is called.

BUG=380087, 624697
==========

[hiroshige, 2016-09-29 09:56:10]

Description was changed from

==========
Remove timing dependency to document onload in dialog-close-event.html

Previously, the layout test fast/dom/HTMLDialogElement/dialog-close-event.html
expected dialog's close event is not called before test completed, because the
dialog's close event should be called asynchronously.

However, if the timing of document's onload event is changed (e.g. by
Issue 624697), the dialog's close event might be called before document's
onload event, i.e. before test completes.

This CL makes the test to check two dialog's close events explicitly, no matter
when document's onload is called.

BUG=380087, 624697
==========

to

==========
Remove timing dependency to document onload in dialog-close-event.html

Previously, the layout test fast/dom/HTMLDialogElement/dialog-close-event.html
expected dialog's close event is not called before test completed, because the
dialog's close event should be called asynchronously.

However, if the timing of document's onload event is changed (e.g. by
Issue 624697), the dialog's close event might be called before document's
onload event, i.e. before test completes.

This CL makes the test to wait until two dialog's close events are called,
no matter when document's onload is called.

BUG=380087, 624697
==========

[hiroshige, 2016-09-29 10:45:50]

Description was changed from

==========
Remove timing dependency to document onload in dialog-close-event.html

Previously, the layout test fast/dom/HTMLDialogElement/dialog-close-event.html
expected dialog's close event is not called before test completed, because the
dialog's close event should be called asynchronously.

However, if the timing of document's onload event is changed (e.g. by
Issue 624697), the dialog's close event might be called before document's
onload event, i.e. before test completes.

This CL makes the test to wait until two dialog's close events are called,
no matter when document's onload is called.

BUG=380087, 624697
==========

to

==========
Remove timing dependency to document onload in dialog-close-event.html

A follow-up of https://codereview.chromium.org/2355743005.

Previously, the layout test fast/dom/HTMLDialogElement/dialog-close-event.html
expected dialog's close event is not called before test completed, because the
dialog's close event should be called asynchronously.

However, if the timing of document's onload event is changed (e.g. by
Issue 624697), the dialog's close event might be called before document's
onload event, i.e. before test completes.

This CL makes the test to wait until two dialog's close events are called,
no matter when document's onload is called.

BUG=380087, 624697
==========

[hiroshige, 2016-09-29 10:45:59]

hiroshige@chromium.org changed reviewers:
+ skobes@chromium.org, xing.xu@intel.com

[hiroshige, 2016-09-29 10:46:00]

PTAL.

https://codereview.chromium.org/2375413002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/dom/HTMLDialogElement/dialog-close-event.html
(right):

https://codereview.chromium.org/2375413002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/dom/HTMLDialogElement/dialog-close-event.html:20:
selfDialog = this;
|self| is renamed because it conflicts with js-test.js.

[xing.xu, 2016-09-29 15:14:56]

On 2016/09/29 10:46:00, hiroshige wrote:
> PTAL.
> 
>
https://codereview.chromium.org/2375413002/diff/20001/third_party/WebKit/Layo...
> File
>
third_party/WebKit/LayoutTests/fast/dom/HTMLDialogElement/dialog-close-event.html
> (right):
> 
>
https://codereview.chromium.org/2375413002/diff/20001/third_party/WebKit/Layo...
>
third_party/WebKit/LayoutTests/fast/dom/HTMLDialogElement/dialog-close-event.html:20:
> selfDialog = this;
> |self| is renamed because it conflicts with js-test.js.

lgtm. Thanks.

[hiroshige, 2016-09-30 05:08:15]

The CQ bit was checked by hiroshige@chromium.org

[commit-bot: I haz the power, 2016-09-30 05:08:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 05:13:29]

Description was changed from

==========
Remove timing dependency to document onload in dialog-close-event.html

A follow-up of https://codereview.chromium.org/2355743005.

Previously, the layout test fast/dom/HTMLDialogElement/dialog-close-event.html
expected dialog's close event is not called before test completed, because the
dialog's close event should be called asynchronously.

However, if the timing of document's onload event is changed (e.g. by
Issue 624697), the dialog's close event might be called before document's
onload event, i.e. before test completes.

This CL makes the test to wait until two dialog's close events are called,
no matter when document's onload is called.

BUG=380087, 624697
==========

to

==========
Remove timing dependency to document onload in dialog-close-event.html

A follow-up of https://codereview.chromium.org/2355743005.

Previously, the layout test fast/dom/HTMLDialogElement/dialog-close-event.html
expected dialog's close event is not called before test completed, because the
dialog's close event should be called asynchronously.

However, if the timing of document's onload event is changed (e.g. by
Issue 624697), the dialog's close event might be called before document's
onload event, i.e. before test completes.

This CL makes the test to wait until two dialog's close events are called,
no matter when document's onload is called.

BUG=380087, 624697
==========

[commit-bot: I haz the power, 2016-09-30 05:13:30]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-30 05:15:38]

Description was changed from

==========
Remove timing dependency to document onload in dialog-close-event.html

A follow-up of https://codereview.chromium.org/2355743005.

Previously, the layout test fast/dom/HTMLDialogElement/dialog-close-event.html
expected dialog's close event is not called before test completed, because the
dialog's close event should be called asynchronously.

However, if the timing of document's onload event is changed (e.g. by
Issue 624697), the dialog's close event might be called before document's
onload event, i.e. before test completes.

This CL makes the test to wait until two dialog's close events are called,
no matter when document's onload is called.

BUG=380087, 624697
==========

to

==========
Remove timing dependency to document onload in dialog-close-event.html

A follow-up of https://codereview.chromium.org/2355743005.

Previously, the layout test fast/dom/HTMLDialogElement/dialog-close-event.html
expected dialog's close event is not called before test completed, because the
dialog's close event should be called asynchronously.

However, if the timing of document's onload event is changed (e.g. by
Issue 624697), the dialog's close event might be called before document's
onload event, i.e. before test completes.

This CL makes the test to wait until two dialog's close events are called,
no matter when document's onload is called.

BUG=380087, 624697

Committed: https://crrev.com/4bc45550a35c63d7e400733e9bdf00114aa13e10
Cr-Commit-Position: refs/heads/master@{#422033}
==========

[commit-bot: I haz the power, 2016-09-30 05:15:39]

Patchset 2 (id:??) landed as
https://crrev.com/4bc45550a35c63d7e400733e9bdf00114aa13e10
Cr-Commit-Position: refs/heads/master@{#422033}