Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Issue 2375393002: Revert of Add CC_LIST and --cc to Gerrit issues via API to be similar to CCs in Rietveld (Closed)

Created:
4 years, 2 months ago by tandrii(chromium)
Modified:
4 years, 2 months ago
Reviewers:
rmistry
CC:
chromium-reviews, tandrii+omg_git_cl_chromium.org, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

Revert of Add CC_LIST and --cc to Gerrit issues via API to be similar to CCs in Rietveld (patchset #4 id:60001 of https://codereview.chromium.org/2378703002/ ) Reason for revert: Actually, it doesn't break uploads, add cc-ed emails post-upload fails with exception and confuses users, and I couldn't find workaround. Original issue's description: > Add CC_LIST and --cc to Gerrit issues via API to be similar to CCs in Rietveld > > BUG=chromium:649660 > > Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/3574740929abd37c45db1d2f8a2c3799bdfe77c5 TBR=rmistry@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:649660 Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/31d165a5c15c7311e0eed1cf731a5585ac9c7f57

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -24 lines) Patch
M gerrit_util.py View 2 chunks +2 lines, -5 lines 0 comments Download
M git_cl.py View 2 chunks +7 lines, -10 lines 0 comments Download
M tests/git_cl_test.py View 4 chunks +4 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
tandrii(chromium)
Created Revert of Add CC_LIST and --cc to Gerrit issues via API to be similar ...
4 years, 2 months ago (2016-09-29 08:40:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2375393002/1
4 years, 2 months ago (2016-09-29 08:40:41 UTC) #3
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 08:40:50 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/31d165a5c15c73...

Powered by Google App Engine
This is Rietveld 408576698