Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Unified Diff: git_cl.py

Issue 2375393002: Revert of Add CC_LIST and --cc to Gerrit issues via API to be similar to CCs in Rietveld (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gerrit_util.py ('k') | tests/git_cl_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: git_cl.py
diff --git a/git_cl.py b/git_cl.py
index bbb8edff02a183f029be8b388ade4c5d613a467e..133713b073bb55d5899a27d7a33d8727a2336a13 100755
--- a/git_cl.py
+++ b/git_cl.py
@@ -2618,6 +2618,13 @@
else:
refspec_opts.append('notify=NONE')
+ cc = self.GetCCList().split(',')
+ if options.cc:
+ cc.extend(options.cc)
+ cc = filter(None, cc)
+ if cc:
+ refspec_opts.extend('cc=' + email.strip() for email in cc)
+
reviewers = change_desc.get_reviewers()
if reviewers:
refspec_opts.extend('r=' + email.strip() for email in reviewers)
@@ -2655,16 +2662,6 @@
'Change-Id: %s') % (len(change_numbers), change_id))
self.SetIssue(change_numbers[0])
self._GitSetBranchConfigValue('gerritsquashhash', ref_to_push)
-
- # Add cc's from the CC_LIST and --cc flag (if any).
- cc = self.GetCCList().split(',')
- if options.cc:
- cc.extend(options.cc)
- cc = filter(None, cc)
- if cc:
- gerrit_util.AddReviewers(
- self._GetGerritHost(), self.GetIssue(), cc, is_reviewer=False)
-
return 0
def _AddChangeIdToCommitMessage(self, options, args):
« no previous file with comments | « gerrit_util.py ('k') | tests/git_cl_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698