Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(535)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Unified Diff: chrome/browser/guest_view/OWNERS
Issue
237533008
:
Refactor GuestView. (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove static iniitalizer by chaning static constent string to char[].
Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Jump to:
chrome/browser/chrome_content_browser_client.cc
chrome/browser/extensions/api/declarative/declarative_api.cc
chrome/browser/extensions/api/webview/webview_api.h
chrome/browser/extensions/menu_manager.cc
chrome/browser/geolocation/chrome_geolocation_permission_context.cc
chrome/browser/guest_view/OWNERS
chrome/browser/guest_view/ad_view/ad_view_constants.h
chrome/browser/guest_view/ad_view/ad_view_constants.cc
chrome/browser/guest_view/ad_view/ad_view_guest.h
chrome/browser/guest_view/ad_view/ad_view_guest.cc
chrome/browser/guest_view/guest_view.h
chrome/browser/guest_view/guest_view_base.h
chrome/browser/guest_view/guest_view_base.cc
chrome/browser/guest_view/guest_view_constants.h
chrome/browser/guest_view/guest_view_constants.cc
chrome/browser/guest_view/web_view/context_menu_content_type_web_view.h
chrome/browser/guest_view/web_view/context_menu_content_type_web_view.cc
chrome/browser/guest_view/web_view/javascript_dialog_helper.h
chrome/browser/guest_view/web_view/javascript_dialog_helper.cc
chrome/browser/guest_view/web_view/plugin_permission_helper.h
chrome/browser/guest_view/web_view/plugin_permission_helper.cc
chrome/browser/guest_view/web_view/web_view_constants.h
chrome/browser/guest_view/web_view/web_view_constants.cc
chrome/browser/guest_view/web_view/web_view_find_helper.h
chrome/browser/guest_view/web_view/web_view_find_helper.cc
chrome/browser/guest_view/web_view/web_view_guest.h
chrome/browser/guest_view/web_view/web_view_guest.cc
chrome/browser/guest_view/web_view/web_view_permission_types.h
chrome/browser/guestview/OWNERS
chrome/browser/guestview/adview/adview_constants.h
chrome/browser/guestview/adview/adview_constants.cc
chrome/browser/guestview/adview/adview_guest.h
chrome/browser/guestview/adview/adview_guest.cc
chrome/browser/guestview/guestview.h
chrome/browser/guestview/guestview.cc
chrome/browser/guestview/guestview_constants.h
chrome/browser/guestview/guestview_constants.cc
chrome/browser/guestview/webview/context_menu_content_type_webview.h
chrome/browser/guestview/webview/context_menu_content_type_webview.cc
chrome/browser/guestview/webview/javascript_dialog_helper.h
chrome/browser/guestview/webview/javascript_dialog_helper.cc
chrome/browser/guestview/webview/plugin_permission_helper.h
chrome/browser/guestview/webview/plugin_permission_helper.cc
chrome/browser/guestview/webview/webview_constants.h
chrome/browser/guestview/webview/webview_constants.cc
chrome/browser/guestview/webview/webview_find_helper.h
chrome/browser/guestview/webview/webview_find_helper.cc
chrome/browser/guestview/webview/webview_guest.h
chrome/browser/guestview/webview/webview_guest.cc
chrome/browser/guestview/webview/webview_permission_types.h
chrome/browser/renderer_context_menu/context_menu_content_type_factory.cc
chrome/browser/renderer_context_menu/render_view_context_menu.cc
chrome/chrome_browser.gypi
View side-by-side diff with in-line comments
Download patch
« no previous file with comments
|
« chrome/browser/geolocation/chrome_geolocation_permission_context.cc
('k') |
chrome/browser/guest_view/ad_view/ad_view_constants.h »
('j') |
chrome/browser/guest_view/ad_view/ad_view_guest.h »
('J')
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
Index: chrome/browser/guest_view/OWNERS
diff --git a/chrome/browser/guestview/OWNERS b/chrome/browser/guest_view/OWNERS
similarity index 100%
rename from chrome/browser/guestview/OWNERS
rename to chrome/browser/guest_view/OWNERS
« no previous file with comments
|
« chrome/browser/geolocation/chrome_geolocation_permission_context.cc
('k') |
chrome/browser/guest_view/ad_view/ad_view_constants.h »
('j') |
chrome/browser/guest_view/ad_view/ad_view_guest.h »
('J')
Issue 237533008: Refactor GuestView. (Closed)
Created 6 years, 8 months ago by Xi Han
Modified 6 years, 8 months ago
Reviewers: Fady Samuel, Dan Beam
Base URL: https://chromium.googlesource.com/chromium/src.git@master
Comments: 18
This is Rietveld
408576698