Refactor GuestView.

chrome/browser/guest_view/ad_view/ad_view_guest.h

Index: chrome/browser/guest_view/ad_view/ad_view_guest.h
diff --git a/chrome/browser/guestview/adview/adview_guest.h b/chrome/browser/guest_view/ad_view/ad_view_guest.h
similarity index 75%
rename from chrome/browser/guestview/adview/adview_guest.h
rename to chrome/browser/guest_view/ad_view/ad_view_guest.h
index f7e391a15dfaec3769296e15d991cec298ffd293..241c7d76a649177ac0d89244d7eb499fdeeca387 100644
--- a/chrome/browser/guestview/adview/adview_guest.h
+++ b/chrome/browser/guest_view/ad_view/ad_view_guest.h
@@ -2,11 +2,11 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef CHROME_BROWSER_GUESTVIEW_ADVIEW_ADVIEW_GUEST_H_
-#define CHROME_BROWSER_GUESTVIEW_ADVIEW_ADVIEW_GUEST_H_
+#ifndef CHROME_BROWSER_GUEST_VIEW_AD_VIEW_AD_VIEW_GUEST_H_
+#define CHROME_BROWSER_GUEST_VIEW_AD_VIEW_AD_VIEW_GUEST_H_
 
 #include "base/values.h"
-#include "chrome/browser/guestview/guestview.h"
+#include "chrome/browser/guest_view/guest_view.h"
 #include "content/public/browser/web_contents_observer.h"
 
 // An AdViewGuest is a WebContentsObserver on the guest WebContents of a
@@ -16,18 +16,13 @@
 // a particular embedder WebContents, we call this "attachment".
 // TODO(fsamuel): There might be an opportunity here to refactor and reuse code
 // between AdViewGuest and WebViewGuest.
-class AdViewGuest : public GuestView,
+class AdViewGuest : public GuestView<AdViewGuest>,
                     public content::WebContentsObserver {
  public:
   AdViewGuest(content::WebContents* guest_web_contents,
               const std::string& extension_id);
 
-  static AdViewGuest* From(int embedder_process_id, int instance_id);
-
-  // GuestView implementation.
-  virtual GuestView::Type GetViewType() const OVERRIDE;
-  virtual WebViewGuest* AsWebView() OVERRIDE;
-  virtual AdViewGuest* AsAdView() OVERRIDE;
+  static const char Type[];

[Xi Han, 2014/04/28 22:08:33]

change to char[].

 
  private:
   virtual ~AdViewGuest();
@@ -51,4 +46,4 @@ class AdViewGuest : public GuestView,
   DISALLOW_COPY_AND_ASSIGN(AdViewGuest);
 };
 
-#endif  // CHROME_BROWSER_GUESTVIEW_ADVIEW_ADVIEW_GUEST_H_
+#endif  // CHROME_BROWSER_GUEST_VIEW_AD_VIEW_AD_VIEW_GUEST_H_