Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2375213002: Restore default-to-zero for subsequence caching record time metric. (Closed)

Created:
4 years, 2 months ago by wkorman
Modified:
4 years, 2 months ago
Reviewers:
sullivan, nednguyen
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Restore default-to-zero for subsequence caching record time metric. http://crrev.com/1552693002 landed as r367465 and added record_time_subsequence_caching_disabled_ms. The current Android reference build is 48.0.2564.95 which is built at r359700. This change is a partial revert of http://crrev.com/2352783004. I've checked the other TODOs I removed and those look to be fine, with the next-newest being http://crrev.com/1104433005 as r326586 which should be present in the Android reference build. BUG=651200 Committed: https://crrev.com/ff30596cef625e4438c6875f7273d5f323367389 Cr-Commit-Position: refs/heads/master@{#421694}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M tools/perf/measurements/rasterize_and_record_micro.py View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 15 (8 generated)
wkorman
4 years, 2 months ago (2016-09-28 21:12:02 UTC) #3
nednguyen
lgtm
4 years, 2 months ago (2016-09-28 21:14:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2375213002/1
4 years, 2 months ago (2016-09-28 21:18:34 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_s5_perf_cq on master.tryserver.chromium.perf (JOB_TIMED_OUT, no build URL) linux_perf_cq on ...
4 years, 2 months ago (2016-09-28 23:19:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2375213002/1
4 years, 2 months ago (2016-09-29 00:25:30 UTC) #11
commit-bot: I haz the power
Failed to apply the patch. On branch working_branch Your branch is up-to-date with 'origin/refs/pending/heads/master'. nothing ...
4 years, 2 months ago (2016-09-29 00:33:04 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 00:45:14 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ff30596cef625e4438c6875f7273d5f323367389
Cr-Commit-Position: refs/heads/master@{#421694}

Powered by Google App Engine
This is Rietveld 408576698