Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Side by Side Diff: tools/perf/measurements/rasterize_and_record_micro.py

Issue 2375213002: Restore default-to-zero for subsequence caching record time metric. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2013 The Chromium Authors. All rights reserved. 1 # Copyright 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import time 5 import time
6 6
7 from telemetry.core import exceptions 7 from telemetry.core import exceptions
8 from telemetry.page import legacy_page_test 8 from telemetry.page import legacy_page_test
9 from telemetry.value import scalar 9 from telemetry.value import scalar
10 10
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
75 results.AddValue(scalar.ScalarValue( 75 results.AddValue(scalar.ScalarValue(
76 results.current_page, 'viewport_picture_size', 'bytes', 76 results.current_page, 'viewport_picture_size', 'bytes',
77 picture_memory_usage)) 77 picture_memory_usage))
78 results.AddValue(scalar.ScalarValue( 78 results.AddValue(scalar.ScalarValue(
79 results.current_page, 'record_time', 'ms', record_time)) 79 results.current_page, 'record_time', 'ms', record_time))
80 80
81 record_time_painting_disabled = data['record_time_painting_disabled_ms'] 81 record_time_painting_disabled = data['record_time_painting_disabled_ms']
82 record_time_caching_disabled = data['record_time_caching_disabled_ms'] 82 record_time_caching_disabled = data['record_time_caching_disabled_ms']
83 record_time_construction_disabled = \ 83 record_time_construction_disabled = \
84 data['record_time_construction_disabled_ms'] 84 data['record_time_construction_disabled_ms']
85 # TODO(wangxianzhu): Remove this workaround when reference builds get past
86 # r367465.
85 record_time_subsequence_caching_disabled = \ 87 record_time_subsequence_caching_disabled = \
86 data['record_time_subsequence_caching_disabled_ms'] 88 data.get('record_time_subsequence_caching_disabled_ms', 0)
87 results.AddValue(scalar.ScalarValue( 89 results.AddValue(scalar.ScalarValue(
88 results.current_page, 'record_time_painting_disabled', 'ms', 90 results.current_page, 'record_time_painting_disabled', 'ms',
89 record_time_painting_disabled)) 91 record_time_painting_disabled))
90 results.AddValue(scalar.ScalarValue( 92 results.AddValue(scalar.ScalarValue(
91 results.current_page, 'record_time_caching_disabled', 'ms', 93 results.current_page, 'record_time_caching_disabled', 'ms',
92 record_time_caching_disabled)) 94 record_time_caching_disabled))
93 results.AddValue(scalar.ScalarValue( 95 results.AddValue(scalar.ScalarValue(
94 results.current_page, 'record_time_construction_disabled', 'ms', 96 results.current_page, 'record_time_construction_disabled', 'ms',
95 record_time_construction_disabled)) 97 record_time_construction_disabled))
96 results.AddValue(scalar.ScalarValue( 98 results.AddValue(scalar.ScalarValue(
(...skipping 29 matching lines...) Expand all
126 results.current_page, 'total_layers', 'count', total_layers)) 128 results.current_page, 'total_layers', 'count', total_layers))
127 results.AddValue(scalar.ScalarValue( 129 results.AddValue(scalar.ScalarValue(
128 results.current_page, 'total_picture_layers', 'count', 130 results.current_page, 'total_picture_layers', 'count',
129 total_picture_layers)) 131 total_picture_layers))
130 results.AddValue(scalar.ScalarValue( 132 results.AddValue(scalar.ScalarValue(
131 results.current_page, 'total_picture_layers_with_no_content', 'count', 133 results.current_page, 'total_picture_layers_with_no_content', 'count',
132 total_picture_layers_with_no_content)) 134 total_picture_layers_with_no_content))
133 results.AddValue(scalar.ScalarValue( 135 results.AddValue(scalar.ScalarValue(
134 results.current_page, 'total_picture_layers_off_screen', 'count', 136 results.current_page, 'total_picture_layers_off_screen', 'count',
135 total_picture_layers_off_screen)) 137 total_picture_layers_off_screen))
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698