Issue 237513004: Implemented custom support for scrollLeft/scrollTop in Element

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 237513004: Implemented custom support for scrollLeft/scrollTop in Element (Closed)

Created:
6 years, 8 months ago by Leaf

Modified:
6 years, 8 months ago

Reviewers:
vsm

CC:
reviews+dom_dartlang.org

Base URL:
svn://svn.chromium.org/blink/branches/dart/1847

Visibility:
Public.

More Reviews

Description

Implemented custom support for scrollLeft/scrollTop in Element Changes to the IDL spec made scrollLeft/scrollTop custom. This patch implements the old behavior (passing in an integer), but not the new extensions (passing in a dictionary). BUG=https://code.google.com/p/dart/issues/detail?id=18062 R=vsm@google.com Committed: https://src.chromium.org/viewvc/multivm/branches/1650/blink?view=rev&revision=171516

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -16 lines)			Patch
	M	Source/bindings/dart/custom/DartElementCustom.cpp	View		2 chunks	+28 lines, -16 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Leaf

6 years, 8 months ago (2014-04-14 23:58:15 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r171516 (presubmit successful).

Expand Messages | Collapse Messages