Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1050)

Issue 2375103002: Missing sibling invalidation across removed element. (Closed)

Created:
4 years, 2 months ago by rune
Modified:
4 years, 2 months ago
Reviewers:
Eric Willigers
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Missing sibling invalidation across removed element. When removing B from siblings A B C, we scheduled invalidations for features of A requiring two adjacent combinators to schedule an invalidation at all. That is fine for rules already affecting C, but for rules kicking in after B is removed, a single combinator is enough. For instance ".a + .c". R=ericwilligers@chromium.org BUG=647780 Review-Url: https://codereview.chromium.org/2362463004 Cr-Commit-Position: refs/heads/master@{#421124} (cherry picked from commit 6e86e7b3077b12108d3a231e75b2da7e3529d04e) Committed: https://chromium.googlesource.com/chromium/src/+/e642be85ee4f7a28fb3ee6e652abdb5b8f149269

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -3 lines) Patch
M third_party/WebKit/LayoutTests/fast/css/invalidation/sibling-mutation-min-direct.html View 3 chunks +18 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/StyleEngine.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
rune
Committed patchset #1 (id:1) manually as e642be85ee4f7a28fb3ee6e652abdb5b8f149269.
4 years, 2 months ago (2016-09-28 16:11:07 UTC) #2
rune
4 years, 2 months ago (2016-09-28 16:11:38 UTC) #3
Eric Willigers
4 years, 2 months ago (2016-09-28 18:22:16 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698