Missing sibling invalidation across removed element.

Missing sibling invalidation across removed element.

When removing B from siblings A B C, we scheduled invalidations for
features of A requiring two adjacent combinators to schedule an
invalidation at all. That is fine for rules already affecting C, but
for rules kicking in after B is removed, a single combinator is enough.
For instance ".a + .c".

R=ericwilligers@chromium.org
BUG=647780
Committed: https://crrev.com/6e86e7b3077b12108d3a231e75b2da7e3529d04e
Cr-Commit-Position: refs/heads/master@{#421124}

[rune, 2016-09-23 09:48:42]

The CQ bit was checked by rune@opera.com to run a CQ dry run

[rune, 2016-09-23 09:48:54]

ptal

[commit-bot: I haz the power, 2016-09-23 09:49:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 10:52:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 10:52:54]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Eric Willigers, 2016-09-23 11:22:51]

The CQ bit was checked by ericwilligers@chromium.org

[Eric Willigers, 2016-09-23 11:22:51]

lgtm

[commit-bot: I haz the power, 2016-09-23 11:23:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Eric Willigers, 2016-09-23 11:26:50]

Perhaps sibling-mutation-min-direct.html should have an extra removeTest,
similar to
https://bugs.chromium.org/p/chromium/issues/detail?id=647780#c13
such that an element would have the incorrect style without this change.

[rune, 2016-09-23 11:58:36]

On 2016/09/23 at 11:26:50, ericwilligers wrote:
> Perhaps sibling-mutation-min-direct.html should have an extra removeTest,
similar to
> https://bugs.chromium.org/p/chromium/issues/detail?id=647780#c13
> such that an element would have the incorrect style without this change.

Done.

[rune, 2016-09-23 11:58:45]

The CQ bit was checked by rune@opera.com

[rune, 2016-09-23 11:58:45]

The patchset sent to the CQ was uploaded after l-g-t-m from
ericwilligers@chromium.org
Link to the patchset: https://codereview.chromium.org/2362463004/#ps20001
(title: "Made separate removal test")

[commit-bot: I haz the power, 2016-09-23 11:58:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 12:03:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 12:03:23]

Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[rune, 2016-09-23 21:10:44]

The CQ bit was checked by rune@opera.com

[commit-bot: I haz the power, 2016-09-23 21:11:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 22:51:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 22:51:04]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[rune, 2016-09-26 09:27:36]

The CQ bit was checked by rune@opera.com

[rune, 2016-09-26 09:27:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
ericwilligers@chromium.org
Link to the patchset: https://codereview.chromium.org/2362463004/#ps40001
(title: "Rebased")

[commit-bot: I haz the power, 2016-09-26 09:27:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-26 10:17:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-26 10:17:22]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[rune, 2016-09-26 11:34:28]

The CQ bit was checked by rune@opera.com

[commit-bot: I haz the power, 2016-09-26 11:34:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-26 12:09:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-26 12:10:00]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[rune, 2016-09-27 05:29:56]

The CQ bit was checked by rune@opera.com

[commit-bot: I haz the power, 2016-09-27 05:30:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 06:10:11]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-27 06:12:31]

Description was changed from

==========
Missing sibling invalidation across removed element.

When removing B from siblings A B C, we scheduled invalidations for
features of A requiring two adjacent combinators to schedule an
invalidation at all. That is fine for rules already affecting C, but
for rules kicking in after B is removed, a single combinator is enough.
For instance ".a + .c".

R=ericwilligers@chromium.org
BUG=647780
==========

to

==========
Missing sibling invalidation across removed element.

When removing B from siblings A B C, we scheduled invalidations for
features of A requiring two adjacent combinators to schedule an
invalidation at all. That is fine for rules already affecting C, but
for rules kicking in after B is removed, a single combinator is enough.
For instance ".a + .c".

R=ericwilligers@chromium.org
BUG=647780

Committed: https://crrev.com/6e86e7b3077b12108d3a231e75b2da7e3529d04e
Cr-Commit-Position: refs/heads/master@{#421124}
==========

[commit-bot: I haz the power, 2016-09-27 06:12:32]

Patchset 3 (id:??) landed as
https://crrev.com/6e86e7b3077b12108d3a231e75b2da7e3529d04e
Cr-Commit-Position: refs/heads/master@{#421124}