Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(695)

Issue 2375083002: Add Memory.RenderAll metrics to track renderers at a higher level. (Closed)

Created:
4 years, 2 months ago by rkaplow
Modified:
4 years, 2 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add Memory.RenderAll metrics to track renderers at a higher level. While I was here, I did the planned obsoletion of Memory.Total. Total2 is good. Owners were suggestions from thread "Memory metrics owners". Happy to fix for other memory metrics if you would like, or you can it yourselves. BUG=651095 Committed: https://crrev.com/8543a4f3d56b771bd13c97df5b3b87ef769679be Cr-Commit-Position: refs/heads/master@{#421831}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -4 lines) Patch
M chrome/browser/metrics/metrics_memory_details.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +27 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
rkaplow
4 years, 2 months ago (2016-09-28 15:46:45 UTC) #3
Alexei Svitkine (slow)
lgtm
4 years, 2 months ago (2016-09-28 15:52:18 UTC) #4
bashi
lgtm
4 years, 2 months ago (2016-09-28 23:36:45 UTC) #5
hajimehoshi
lgtm
4 years, 2 months ago (2016-09-29 04:29:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2375083002/1
4 years, 2 months ago (2016-09-29 14:52:04 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-29 15:54:01 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 15:56:23 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8543a4f3d56b771bd13c97df5b3b87ef769679be
Cr-Commit-Position: refs/heads/master@{#421831}

Powered by Google App Engine
This is Rietveld 408576698