Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Unified Diff: chrome/browser/metrics/metrics_memory_details.cc

Issue 2375083002: Add Memory.RenderAll metrics to track renderers at a higher level. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/metrics/metrics_memory_details.cc
diff --git a/chrome/browser/metrics/metrics_memory_details.cc b/chrome/browser/metrics/metrics_memory_details.cc
index 3a798d8cd40027b51c4f89ae7f213344c62dbd91..f8ccb556074e1419b88758d1fd1ffa04f65a2f80 100644
--- a/chrome/browser/metrics/metrics_memory_details.cc
+++ b/chrome/browser/metrics/metrics_memory_details.cc
@@ -72,7 +72,6 @@ void MetricsMemoryDetails::OnDetailsAvailable() {
void MetricsMemoryDetails::UpdateHistograms() {
// Reports a set of memory metrics to UMA.
- // Memory is measured in KB.
const ProcessData& browser = *ChromeBrowser();
size_t aggregate_memory = 0;
@@ -97,6 +96,9 @@ void MetricsMemoryDetails::UpdateHistograms() {
committed / 1024);
continue;
case content::PROCESS_TYPE_RENDERER: {
+ UMA_HISTOGRAM_MEMORY_LARGE_MB("Memory.RendererAll", sample / 1024);
+ UMA_HISTOGRAM_MEMORY_LARGE_MB("Memory.RendererAll.Committed",
+ committed / 1024);
ProcessMemoryInformation::RendererProcessType renderer_type =
browser.processes[index].renderer_type;
switch (renderer_type) {
@@ -200,9 +202,6 @@ void MetricsMemoryDetails::UpdateHistograms() {
// TODO(viettrungluu): Do we want separate counts for the other
// (platform-specific) process types?
- // TODO(rkaplow): Remove once we've verified Memory.Total2 is ok.
- int total_sample_old = static_cast<int>(aggregate_memory / 1000);
- UMA_HISTOGRAM_MEMORY_MB("Memory.Total", total_sample_old);
int total_sample = static_cast<int>(aggregate_memory / 1024);
UMA_HISTOGRAM_MEMORY_LARGE_MB("Memory.Total2", total_sample);
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698