cocoa browser: remove non-MD location bar support

cocoa browser: remove non-MD location bar support

This change also removes a bunch of references to material design in
toolbar_controller which were left over from CL 2361153002.

BUG=649368
Committed: https://crrev.com/b0be64d05e817e818702aa0144abaaa5e6fb2945
Cr-Commit-Position: refs/heads/master@{#421600}

[Elly Fong-Jones, 2016-09-28 11:05:02]

Description was changed from

==========
cocoa browser: remove non-MD location bar support

This change also removes a bunch of references to material design in
toolbar_controller which were left over from CL 2361153002.

BUG=649368
==========

to

==========
cocoa browser: remove non-MD location bar support

This change also removes a bunch of references to material design in
toolbar_controller which were left over from CL 2361153002.

BUG=649368
==========

[Elly Fong-Jones, 2016-09-28 11:05:02]

ellyjones@chromium.org changed reviewers:
+ avi@chromium.org

[Elly Fong-Jones, 2016-09-28 11:05:08]

avi: ptal? :)

[Avi (use Gerrit), 2016-09-28 16:01:58]

Lots of things that are a bit more serious than nits, but LGTM for commit once
you fix 'em.

https://codereview.chromium.org/2375033002/diff/1/chrome/browser/ui/cocoa/loc...
File chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm
(right):

https://codereview.chromium.org/2375033002/diff/1/chrome/browser/ui/cocoa/loc...
chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm:38: }
Put this back to being a "const CGFloat" like line 34.

https://codereview.chromium.org/2375033002/diff/1/chrome/browser/ui/cocoa/loc...
chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm:44: return
kDecorationHorizontalPad;
ditto

https://codereview.chromium.org/2375033002/diff/1/chrome/browser/ui/cocoa/loc...
File chrome/browser/ui/cocoa/location_bar/bubble_decoration.mm (right):

https://codereview.chromium.org/2375033002/diff/1/chrome/browser/ui/cocoa/loc...
chrome/browser/ui/cocoa/location_bar/bubble_decoration.mm:25: }
return to being a const CGFloat like lines 20, 28, 34, etc.

Why is line 31 non-const? Ew, make const.

https://codereview.chromium.org/2375033002/diff/1/chrome/browser/ui/cocoa/loc...
File chrome/browser/ui/cocoa/location_bar/content_setting_decoration.mm (right):

https://codereview.chromium.org/2375033002/diff/1/chrome/browser/ui/cocoa/loc...
chrome/browser/ui/cocoa/location_bar/content_setting_decoration.mm:71: return
kLeftDividerPadding + kRightDividerPadding;
can we make this

const CGFloat kDividerPadding = kLeftDividerPadding + kRightDividerPadding?

https://codereview.chromium.org/2375033002/diff/1/chrome/browser/ui/cocoa/loc...
File
chrome/browser/ui/cocoa/location_bar/manage_passwords_decoration_unittest.mm
(right):

https://codereview.chromium.org/2375033002/diff/1/chrome/browser/ui/cocoa/loc...
chrome/browser/ui/cocoa/location_bar/manage_passwords_decoration_unittest.mm:107:
// gfx::VectorIconId::AUTOLOGIN in Material Design - fail the test if
What is this "-"? This feels more semicolon to me. Possibly a ", so" or ",
therefore" if not.

https://codereview.chromium.org/2375033002/diff/1/chrome/browser/ui/cocoa/too...
File chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm (right):

https://codereview.chromium.org/2375033002/diff/1/chrome/browser/ui/cocoa/too...
chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm:308: kElementPadding +
kButtonInset;
Some of these can be rewrapped. Try a clang format on it.

[Elly Fong-Jones, 2016-09-28 19:02:28]

https://codereview.chromium.org/2375033002/diff/1/chrome/browser/ui/cocoa/loc...
File chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm
(right):

https://codereview.chromium.org/2375033002/diff/1/chrome/browser/ui/cocoa/loc...
chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm:38: }
On 2016/09/28 16:01:57, Avi wrote:
> Put this back to being a "const CGFloat" like line 34.

Done.

https://codereview.chromium.org/2375033002/diff/1/chrome/browser/ui/cocoa/loc...
chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm:44: return
kDecorationHorizontalPad;
On 2016/09/28 16:01:58, Avi wrote:
> ditto

Done.

https://codereview.chromium.org/2375033002/diff/1/chrome/browser/ui/cocoa/loc...
File chrome/browser/ui/cocoa/location_bar/bubble_decoration.mm (right):

https://codereview.chromium.org/2375033002/diff/1/chrome/browser/ui/cocoa/loc...
chrome/browser/ui/cocoa/location_bar/bubble_decoration.mm:25: }
On 2016/09/28 16:01:58, Avi wrote:
> return to being a const CGFloat like lines 20, 28, 34, etc.
> 
> Why is line 31 non-const? Ew, make const.

Done.

https://codereview.chromium.org/2375033002/diff/1/chrome/browser/ui/cocoa/loc...
File chrome/browser/ui/cocoa/location_bar/content_setting_decoration.mm (right):

https://codereview.chromium.org/2375033002/diff/1/chrome/browser/ui/cocoa/loc...
chrome/browser/ui/cocoa/location_bar/content_setting_decoration.mm:71: return
kLeftDividerPadding + kRightDividerPadding;
On 2016/09/28 16:01:58, Avi wrote:
> can we make this
> 
> const CGFloat kDividerPadding = kLeftDividerPadding + kRightDividerPadding?

Done.

https://codereview.chromium.org/2375033002/diff/1/chrome/browser/ui/cocoa/loc...
File
chrome/browser/ui/cocoa/location_bar/manage_passwords_decoration_unittest.mm
(right):

https://codereview.chromium.org/2375033002/diff/1/chrome/browser/ui/cocoa/loc...
chrome/browser/ui/cocoa/location_bar/manage_passwords_decoration_unittest.mm:107:
// gfx::VectorIconId::AUTOLOGIN in Material Design - fail the test if
On 2016/09/28 16:01:58, Avi wrote:
> What is this "-"? This feels more semicolon to me. Possibly a ", so" or ",
> therefore" if not.

Done.

https://codereview.chromium.org/2375033002/diff/1/chrome/browser/ui/cocoa/too...
File chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm (right):

https://codereview.chromium.org/2375033002/diff/1/chrome/browser/ui/cocoa/too...
chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm:308: kElementPadding +
kButtonInset;
On 2016/09/28 16:01:58, Avi wrote:
> Some of these can be rewrapped. Try a clang format on it.

Done.

[Elly Fong-Jones, 2016-09-28 19:02:31]

The CQ bit was checked by ellyjones@chromium.org

[Elly Fong-Jones, 2016-09-28 19:02:31]

The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org
Link to the patchset: https://codereview.chromium.org/2375033002/#ps20001
(title: "fix nits")

[commit-bot: I haz the power, 2016-09-28 19:03:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 19:23:54]

Description was changed from

==========
cocoa browser: remove non-MD location bar support

This change also removes a bunch of references to material design in
toolbar_controller which were left over from CL 2361153002.

BUG=649368
==========

to

==========
cocoa browser: remove non-MD location bar support

This change also removes a bunch of references to material design in
toolbar_controller which were left over from CL 2361153002.

BUG=649368
==========

[commit-bot: I haz the power, 2016-09-28 19:23:55]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-28 19:26:23]

Description was changed from

==========
cocoa browser: remove non-MD location bar support

This change also removes a bunch of references to material design in
toolbar_controller which were left over from CL 2361153002.

BUG=649368
==========

to

==========
cocoa browser: remove non-MD location bar support

This change also removes a bunch of references to material design in
toolbar_controller which were left over from CL 2361153002.

BUG=649368

Committed: https://crrev.com/b0be64d05e817e818702aa0144abaaa5e6fb2945
Cr-Commit-Position: refs/heads/master@{#421600}
==========

[commit-bot: I haz the power, 2016-09-28 19:26:26]

Patchset 2 (id:??) landed as
https://crrev.com/b0be64d05e817e818702aa0144abaaa5e6fb2945
Cr-Commit-Position: refs/heads/master@{#421600}