chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell_unittest.mm - Issue 2375033002: cocoa browser: remove non-MD location bar support

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell_unittest.mm

Issue 2375033002: cocoa browser: remove non-MD location bar support (Closed)

Patch Set: fix nits Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm ('k') | chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell_unittest.mm

diff --git a/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell_unittest.mm b/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell_unittest.mm

index 2edcbcec7d174c9e373284af7a0c6e2fa058cfac..5d7520ece587858ab437c9b74f6a16cb351c2b0c 100644

--- a/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell_unittest.mm

+++ b/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell_unittest.mm

@@ -165,11 +165,7 @@ SecurityStateBubbleDecoration security_state_bubble_decoration(

textFrame = [cell textFrameForFrame:bounds];

EXPECT_FALSE(NSIsEmptyRect(textFrame));

EXPECT_TRUE(NSContainsRect(bounds, textFrame));

- if (ui::MaterialDesignController::IsModeMaterial()) {

- EXPECT_EQ(1, NSMinX(textFrame));

- } else {

- EXPECT_EQ(NSMinX(bounds), NSMinX(textFrame));

- }

+ EXPECT_EQ(1, NSMinX(textFrame));

EXPECT_EQ(NSMaxX(bounds), NSMaxX(textFrame));

EXPECT_TRUE(NSContainsRect(cursorFrame, textFrame));