Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Issue 23749004: Move more options to browser options. (Closed)

Created:
7 years, 3 months ago by achuithb
Modified:
7 years, 3 months ago
Reviewers:
dtu, tonyg
CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org
Visibility:
Public.

Description

dont_override_profile, profile_type, profile_dir, extra_browser_args, extra_wpr_args moved to browser_options. BUG=269131 TEST=manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221841

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Patch Set 4 : fixups #

Messages

Total messages: 7 (0 generated)
achuithb
Dave, Tony, please take a look
7 years, 3 months ago (2013-09-06 21:28:52 UTC) #1
tonyg
lgtm Should probably wait for dtu to have a look though
7 years, 3 months ago (2013-09-06 21:37:25 UTC) #2
achuithb
On 2013/09/06 21:37:25, tonyg wrote: > lgtm > > Should probably wait for dtu to ...
7 years, 3 months ago (2013-09-06 21:50:26 UTC) #3
dtu
lgtm
7 years, 3 months ago (2013-09-06 21:58:19 UTC) #4
achuithb
On 2013/09/06 21:58:19, Dave Tu wrote: > lgtm ty!
7 years, 3 months ago (2013-09-06 22:09:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achuith@chromium.org/23749004/9001
7 years, 3 months ago (2013-09-06 22:10:37 UTC) #6
commit-bot: I haz the power
7 years, 3 months ago (2013-09-07 00:56:12 UTC) #7
Message was sent while issue was closed.
Change committed as 221841

Powered by Google App Engine
This is Rietveld 408576698