tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py - Issue 23749004: Move more options to browser options.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py

Issue 23749004: Move more options to browser options. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fixups Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py ('k') | tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py

diff --git a/tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py b/tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py

index 876f90992d56afa675ac1167173c5238584be99a..218601394454a27e3a0ae1f05c5092fc2eb6abd7 100644

--- a/tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py

+++ b/tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py

@@ -46,7 +46,7 @@ class ChromeBrowserBackend(browser_backend.BrowserBackend):

self.webpagereplay_remote_http_port = self.webpagereplay_local_http_port

self.webpagereplay_remote_https_port = self.webpagereplay_local_https_port

- if (finder_options.dont_override_profile and

+ if (self.browser_options.dont_override_profile and

not options_for_unittests.AreSet()):

sys.stderr.write('Warning: Not overriding profile. This can cause '

'unexpected effects due to profile-specific settings, '

@@ -74,7 +74,7 @@ class ChromeBrowserBackend(browser_backend.BrowserBackend):

def GetBrowserStartupArgs(self):

args = []

- args.extend(self.finder_options.extra_browser_args)

+ args.extend(self.browser_options.extra_browser_args)

args.append('--disable-background-networking')

args.append('--metrics-recording-only')

args.append('--no-first-run')