Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Unified Diff: components/content_settings/core/browser/content_settings_usages_state.cc

Issue 2374443003: Fix content settings's cookie code to work with PlzNavigate. (Closed)
Patch Set: review comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/content_settings/core/browser/content_settings_usages_state.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/content_settings/core/browser/content_settings_usages_state.cc
diff --git a/components/content_settings/core/browser/content_settings_usages_state.cc b/components/content_settings/core/browser/content_settings_usages_state.cc
index b0486a90758c62f37b75c0ee617908c1df5152db..0619ff3ffc64cffb4c7ce7def7958b85cd9ccf56 100644
--- a/components/content_settings/core/browser/content_settings_usages_state.cc
+++ b/components/content_settings/core/browser/content_settings_usages_state.cc
@@ -10,12 +10,6 @@
#include "components/content_settings/core/browser/host_content_settings_map.h"
#include "components/url_formatter/url_formatter.h"
-ContentSettingsUsagesState::CommittedDetails::CommittedDetails()
- : current_url_valid(false) {
-}
-
-ContentSettingsUsagesState::CommittedDetails::~CommittedDetails() {}
-
ContentSettingsUsagesState::ContentSettingsUsagesState(
HostContentSettingsMap* host_content_settings_map,
ContentSettingsType type)
@@ -33,12 +27,10 @@ void ContentSettingsUsagesState::OnPermissionSet(
}
void ContentSettingsUsagesState::DidNavigate(const CommittedDetails& details) {
- if (details.current_url_valid)
- embedder_url_ = details.current_url;
+ embedder_url_ = details.current_url;
if (state_map_.empty())
return;
- if (!details.current_url_valid ||
- details.previous_url.GetOrigin() != details.current_url.GetOrigin()) {
+ if (details.previous_url.GetOrigin() != details.current_url.GetOrigin()) {
state_map_.clear();
return;
}
« no previous file with comments | « components/content_settings/core/browser/content_settings_usages_state.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698