Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(968)

Unified Diff: chrome/browser/ui/views/toolbar/toolbar_view.h

Issue 2374253002: Fix bookmark bubble/star view highlighting for Harmony. (Closed)
Patch Set: fix tests, move bubble creation to toolbar Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/toolbar/toolbar_view.h
diff --git a/chrome/browser/ui/views/toolbar/toolbar_view.h b/chrome/browser/ui/views/toolbar/toolbar_view.h
index b8458bcd55c7f58fd8eed710b51f0e21f7a9b5de..2757487338eac1f069e6ea7f9d6f5adadcdac127 100644
--- a/chrome/browser/ui/views/toolbar/toolbar_view.h
+++ b/chrome/browser/ui/views/toolbar/toolbar_view.h
@@ -28,6 +28,10 @@ class HomeButton;
class ReloadButton;
class ToolbarButton;
+namespace bookmarks {
+class BookmarkBubbleObserver;
+}
+
namespace extensions {
class Command;
class Extension;
@@ -71,8 +75,10 @@ class ToolbarView : public views::AccessiblePaneView,
virtual bool GetAcceleratorInfo(int id, ui::Accelerator* accel);
- // Returns the view to which the bookmark bubble should be anchored.
- views::View* GetBookmarkBubbleAnchor();
+ // Shows a bookmark bubble and anchors it appropriately.
+ void ShowBookmarkBubble(const GURL& url,
+ bool already_bookmarked,
+ bookmarks::BookmarkBubbleObserver* observer);
// Returns the view to which the "Save credit card" bubble should be anchored.
views::View* GetSaveCreditCardBubbleAnchor();

Powered by Google App Engine
This is Rietveld 408576698