chrome/browser/ui/views/passwords/manage_passwords_icon_view_interactive_uitest.cc - Issue 2374253002: Fix bookmark bubble/star view highlighting for Harmony.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/passwords/manage_passwords_icon_view_interactive_uitest.cc

Issue 2374253002: Fix bookmark bubble/star view highlighting for Harmony. (Closed)

Patch Set: fix tests, move bubble creation to toolbar Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/passwords/manage_passwords_bubble_view_interactive_uitest.cc ('k') | chrome/browser/ui/views/toolbar/toolbar_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/passwords/manage_passwords_icon_view_interactive_uitest.cc

diff --git a/chrome/browser/ui/views/passwords/manage_passwords_icon_view_interactive_uitest.cc b/chrome/browser/ui/views/passwords/manage_passwords_icon_view_interactive_uitest.cc

index e045498a689dc1fab6fd6d75fd7a281a1cd65ae1..1295b741795361c2e7e54c568f8ca0a2b9b3347a 100644

--- a/chrome/browser/ui/views/passwords/manage_passwords_icon_view_interactive_uitest.cc

+++ b/chrome/browser/ui/views/passwords/manage_passwords_icon_view_interactive_uitest.cc

@@ -25,9 +25,7 @@ class ManagePasswordsIconViewTest : public ManagePasswordsTest {

ManagePasswordsIconView* view() override {

BrowserView* browser_view = static_cast<BrowserView*>(browser()->window());

return static_cast<ManagePasswordsIconViews*>(

- browser_view->GetToolbarView()

- ->location_bar()

- ->manage_passwords_icon_view());

+ browser_view->toolbar()->location_bar()->manage_passwords_icon_view());

}

password_manager::ui::State ViewState() { return GetView()->state_; }