Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(983)

Issue 2374123005: Revert of [builtins] migrate C++ String Iterator builtins to baseline TurboFan (Closed)

Created:
4 years, 2 months ago by Jakob Kummerow
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [builtins] migrate C++ String Iterator builtins to baseline TurboFan (patchset #13 id:260001 of https://codereview.chromium.org/2358263002/ ) Reason for revert: Introduces an infinite loop (see comment). Original issue's description: > [builtins] migrate C++ String Iterator builtins to baseline TurboFan > > Migrate newly added C++ String Iterator builtins to TFJ builtins, per > step 4. of the String Iterator Baseline Implementation section of the design doc > > BUG=v8:5388 > R=bmeurer@chromium.org, mstarzinger@chromium.org > > Committed: https://crrev.com/f9a2c8b1112c4e915df8bc5f7ea1fccdf7a33ff8 > Cr-Commit-Position: refs/heads/master@{#39765} TBR=bmeurer@chromium.org,mstarzinger@chromium.org,caitp@igalia.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=v8:5388 Committed: https://crrev.com/145d21af6eee30ac73fbc59e451f604e07206de4 Cr-Commit-Position: refs/heads/master@{#39870}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -512 lines) Patch
M src/bootstrapper.cc View 1 chunk +3 lines, -11 lines 0 comments Download
M src/builtins/builtins.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/builtins/builtins-string.cc View 1 chunk +51 lines, -436 lines 0 comments Download
M src/code-stub-assembler.h View 2 chunks +0 lines, -9 lines 0 comments Download
M src/code-stub-assembler.cc View 1 chunk +0 lines, -52 lines 0 comments Download
M src/objects-debug.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
Jakob Kummerow
Created Revert of [builtins] migrate C++ String Iterator builtins to baseline TurboFan
4 years, 2 months ago (2016-09-29 13:30:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2374123005/1
4 years, 2 months ago (2016-09-29 13:30:52 UTC) #3
caitp
On 2016/09/29 13:30:52, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
4 years, 2 months ago (2016-09-29 13:32:07 UTC) #4
caitp
On 2016/09/29 13:30:52, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
4 years, 2 months ago (2016-09-29 13:32:11 UTC) #5
Jakob Kummerow
On 2016/09/29 13:32:07, caitp wrote: > Where is the comment referred to in the CL ...
4 years, 2 months ago (2016-09-29 13:33:02 UTC) #6
caitp
On 2016/09/29 13:33:02, Jakob Kummerow wrote: > On 2016/09/29 13:32:07, caitp wrote: > > Where ...
4 years, 2 months ago (2016-09-29 13:36:19 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-29 14:08:54 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 14:09:22 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/145d21af6eee30ac73fbc59e451f604e07206de4
Cr-Commit-Position: refs/heads/master@{#39870}

Powered by Google App Engine
This is Rietveld 408576698