Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Issue 2374013004: MIPS32: Remove EXTRA, NORMAL instruction type check. (Closed)

Created:
4 years, 2 months ago by balazs.kilvady
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Remove EXTRA, NORMAL instruction type check. BUG= Committed: https://crrev.com/ee605756b3b92f4b3b23874eef8eed276271a8eb Cr-Commit-Position: refs/heads/master@{#39904}

Patch Set 1 #

Patch Set 2 : Add comments. #

Patch Set 3 : Rebase. #

Patch Set 4 : Add 64-bit port. #

Patch Set 5 : Fix indentation. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -50 lines) Patch
M src/mips/constants-mips.h View 1 5 chunks +10 lines, -22 lines 0 comments Download
M src/mips/disasm-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/simulator-mips.h View 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/constants-mips64.h View 1 2 3 4 4 chunks +6 lines, -24 lines 0 comments Download
M src/mips64/disasm-mips64.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/simulator-mips64.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 22 (15 generated)
balazs.kilvady
4 years, 2 months ago (2016-09-29 10:42:21 UTC) #2
ivica.bogosavljevic
On 2016/09/29 10:42:21, balazs.kilvady wrote: lgtm
4 years, 2 months ago (2016-09-30 08:30:22 UTC) #11
ivica.bogosavljevic
4 years, 2 months ago (2016-09-30 08:30:29 UTC) #12
miran.karic
lgtm
4 years, 2 months ago (2016-09-30 08:42:40 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2374013004/80001
4 years, 2 months ago (2016-09-30 08:58:55 UTC) #18
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 2 months ago (2016-09-30 09:01:35 UTC) #20
commit-bot: I haz the power
4 years, 2 months ago (2016-09-30 09:01:48 UTC) #22
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/ee605756b3b92f4b3b23874eef8eed276271a8eb
Cr-Commit-Position: refs/heads/master@{#39904}

Powered by Google App Engine
This is Rietveld 408576698