MIPS: Improve performance of simulator in debug mode.

MIPS: Improve performance of simulator in debug mode.

The running time of optdebug.quickcheck is improved by 8% while a more strict DCHECKing is kept in simulator.

Committed: https://crrev.com/639e8fa4cd84d803088b725d5401cf01fe24d8a5
Cr-Commit-Position: refs/heads/master@{#39667}

[balazs.kilvady, 2016-09-22 09:26:46]

Description was changed from

==========
MIPS: More refinement of Instruction class(es).


MIPS: Refine Instruction class.

BUG=
==========

to

==========
MIPS: Improve performance of simulator in debug mode.
==========

[balazs.kilvady, 2016-09-22 09:33:02]

balazs.kilvady@imgtec.com changed reviewers:
+ akos.palfi@imgtec.com, gergely.kis@imgtec.com,
ilija.pavlovic.imgtec@gmail.com, ivica.bogosavljevic@imgtec.com,
marija.antic@imgtec.com, miran.karic@imgtec.com

[miran.karic, 2016-09-22 12:24:06]

miran.karic@imgtec.com changed reviewers:
+ Miran.Karic@imgtec.com

[miran.karic, 2016-09-22 12:24:06]

LGTM with a nit.

https://codereview.chromium.org/1349403003/diff/40001/src/mips/simulator-mips.h
File src/mips/simulator-mips.h (right):

https://codereview.chromium.org/1349403003/diff/40001/src/mips/simulator-mips...
src/mips/simulator-mips.h:360: //  inline Instruction* get_instr() const {
return instr_.instr(); }
Is there a reason to keep these commented out functions?

[balazs.kilvady, 2016-09-22 16:45:53]

Description was changed from

==========
MIPS: Improve performance of simulator in debug mode.
==========

to

==========
MIPS: Improve performance of simulator in debug mode.

The running time of optdebug.quickcheck is improved by 8% while a more strict
DCHECKing is kept in simulator.
==========

[balazs.kilvady, 2016-09-22 16:45:53]

balazs.kilvady@imgtec.com changed reviewers:
- Miran.Karic@imgtec.com

[balazs.kilvady, 2016-09-22 16:46:10]

https://codereview.chromium.org/1349403003/diff/40001/src/mips/simulator-mips.h
File src/mips/simulator-mips.h (right):

https://codereview.chromium.org/1349403003/diff/40001/src/mips/simulator-mips...
src/mips/simulator-mips.h:360: //  inline Instruction* get_instr() const {
return instr_.instr(); }
On 2016/09/22 12:24:06, miran.karic wrote:
> Is there a reason to keep these commented out functions?

Done.

[balazs.kilvady, 2016-09-22 16:46:25]

The CQ bit was checked by balazs.kilvady@imgtec.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-22 16:46:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 16:51:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-22 16:51:18]

Dry run: Try jobs failed on following builders:
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/24759)

[balazs.kilvady, 2016-09-23 09:52:08]

Patchset #5 (id:80001) has been deleted

[balazs.kilvady, 2016-09-23 09:56:12]

The CQ bit was checked by balazs.kilvady@imgtec.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-23 09:56:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[balazs.kilvady, 2016-09-23 10:20:26]

The CQ bit was unchecked by balazs.kilvady@imgtec.com

[balazs.kilvady, 2016-09-23 10:20:36]

The CQ bit was checked by balazs.kilvady@imgtec.com

[balazs.kilvady, 2016-09-23 10:20:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
Miran.Karic@imgtec.com
Link to the patchset: https://codereview.chromium.org/1349403003/#ps100001
(title: "Fix format.")

[commit-bot: I haz the power, 2016-09-23 10:20:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 11:56:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 11:56:59]

Try jobs failed on following builders:
  v8_win64_rel_ng on master.tryserver.v8 (JOB_TIMED_OUT, no build URL)
  v8_win_compile_dbg on master.tryserver.v8 (JOB_TIMED_OUT, no build URL)
  v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_TIMED_OUT, no build
URL)
  v8_win_rel_ng on master.tryserver.v8 (JOB_TIMED_OUT, no build URL)

[balazs.kilvady, 2016-09-23 13:32:19]

The CQ bit was checked by balazs.kilvady@imgtec.com

[commit-bot: I haz the power, 2016-09-23 13:32:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 13:35:29]

Description was changed from

==========
MIPS: Improve performance of simulator in debug mode.

The running time of optdebug.quickcheck is improved by 8% while a more strict
DCHECKing is kept in simulator.
==========

to

==========
MIPS: Improve performance of simulator in debug mode.

The running time of optdebug.quickcheck is improved by 8% while a more strict
DCHECKing is kept in simulator.
==========

[commit-bot: I haz the power, 2016-09-23 13:35:30]

Committed patchset #5 (id:100001)

[commit-bot: I haz the power, 2016-09-23 13:35:46]

Description was changed from

==========
MIPS: Improve performance of simulator in debug mode.

The running time of optdebug.quickcheck is improved by 8% while a more strict
DCHECKing is kept in simulator.
==========

to

==========
MIPS: Improve performance of simulator in debug mode.

The running time of optdebug.quickcheck is improved by 8% while a more strict
DCHECKing is kept in simulator.

Committed: https://crrev.com/639e8fa4cd84d803088b725d5401cf01fe24d8a5
Cr-Commit-Position: refs/heads/master@{#39667}
==========

[commit-bot: I haz the power, 2016-09-23 13:35:47]

Patchset 5 (id:??) landed as
https://crrev.com/639e8fa4cd84d803088b725d5401cf01fe24d8a5
Cr-Commit-Position: refs/heads/master@{#39667}