MemoryCoordinatorClient's destructor should be protected-virtual

MemoryCoordinatorClient's destructor should be protected-virtual

A public destructor on a pure-virtual interface is a signal that any
consumer of that interface is free to deallocate the structure.
That's not required of the API of MemoryCoordinatorClient. By making
the constructor protected-virtual, we are signaling that the API
contract of the MemoryCoordinatorClient makes no requirements on
the implementation.

BUG=639700
Committed: https://crrev.com/8b5c3660468238feee6e9b2fa38690d2e34e86f7
Cr-Commit-Position: refs/heads/master@{#421736}

[bashi, 2016-09-29 02:30:16]

The CQ bit was checked by bashi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-29 02:30:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bashi, 2016-09-29 02:31:42]

bashi@chromium.org changed reviewers:
+ dcheng@chromium.org

[bashi, 2016-09-29 02:31:43]

dcheng@: could you review this as an owner of base/ ?

This is suggested in https://codereview.chromium.org/2359723006/#msg20

[dcheng, 2016-09-29 02:36:05]

lgtm

[commit-bot: I haz the power, 2016-09-29 03:26:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-29 03:26:22]

Dry run: This issue passed the CQ dry run.

[bashi, 2016-09-29 03:27:04]

The CQ bit was checked by bashi@chromium.org

[commit-bot: I haz the power, 2016-09-29 03:27:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-29 03:41:04]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-29 03:43:38]

Description was changed from

==========
MemoryCoordinatorClient's destructor should be protected-virtual

A public destructor on a pure-virtual interface is a signal that any
consumer of that interface is free to deallocate the structure.
That's not required of the API of MemoryCoordinatorClient. By making
the constructor protected-virtual, we are signaling that the API
contract of the MemoryCoordinatorClient makes no requirements on
the implementation.

BUG=639700
==========

to

==========
MemoryCoordinatorClient's destructor should be protected-virtual

A public destructor on a pure-virtual interface is a signal that any
consumer of that interface is free to deallocate the structure.
That's not required of the API of MemoryCoordinatorClient. By making
the constructor protected-virtual, we are signaling that the API
contract of the MemoryCoordinatorClient makes no requirements on
the implementation.

BUG=639700

Committed: https://crrev.com/8b5c3660468238feee6e9b2fa38690d2e34e86f7
Cr-Commit-Position: refs/heads/master@{#421736}
==========

[commit-bot: I haz the power, 2016-09-29 03:43:39]

Patchset 1 (id:??) landed as
https://crrev.com/8b5c3660468238feee6e9b2fa38690d2e34e86f7
Cr-Commit-Position: refs/heads/master@{#421736}

[hajimehoshi, 2016-09-29 04:19:25]

lgtm