Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 2374003002: [ic][mips][mips64] Ensure store handlers return value in proper register. (Closed)

Created:
4 years, 2 months ago by Igor Sheludko
Modified:
4 years, 2 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ic][mips][mips64] Ensure store handlers return value in proper register. BUG=chromium:650973 Committed: https://crrev.com/8d8c134b12c6309723314d82cf24bea4a0175268 Cr-Commit-Position: refs/heads/master@{#39823}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -14 lines) Patch
M src/ic/mips/handler-compiler-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic/mips/ic-mips.cc View 4 chunks +8 lines, -4 lines 0 comments Download
M src/ic/mips64/handler-compiler-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic/mips64/ic-mips64.cc View 4 chunks +8 lines, -4 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-650973.js View 1 chunk +7 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Igor Sheludko
PTAL
4 years, 2 months ago (2016-09-28 10:41:10 UTC) #5
Jakob Kummerow
lgtm
4 years, 2 months ago (2016-09-28 11:03:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2374003002/1
4 years, 2 months ago (2016-09-28 11:44:09 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-28 11:46:30 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 11:46:56 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8d8c134b12c6309723314d82cf24bea4a0175268
Cr-Commit-Position: refs/heads/master@{#39823}

Powered by Google App Engine
This is Rietveld 408576698