Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/ic/mips64/handler-compiler-mips64.cc

Issue 2374003002: [ic][mips][mips64] Ensure store handlers return value in proper register. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ic/mips/ic-mips.cc ('k') | src/ic/mips64/ic-mips64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_MIPS64 5 #if V8_TARGET_ARCH_MIPS64
6 6
7 #include "src/ic/handler-compiler.h" 7 #include "src/ic/handler-compiler.h"
8 8
9 #include "src/api-arguments.h" 9 #include "src/api-arguments.h"
10 #include "src/field-type.h" 10 #include "src/field-type.h"
(...skipping 645 matching lines...) Expand 10 before | Expand all | Expand 10 after
656 __ LoadRoot(at, Heap::kTheHoleValueRootIndex); 656 __ LoadRoot(at, Heap::kTheHoleValueRootIndex);
657 __ Branch(&miss, eq, result, Operand(at)); 657 __ Branch(&miss, eq, result, Operand(at));
658 } 658 }
659 659
660 Counters* counters = isolate()->counters(); 660 Counters* counters = isolate()->counters();
661 __ IncrementCounter(counters->ic_named_load_global_stub(), 1, a1, a3); 661 __ IncrementCounter(counters->ic_named_load_global_stub(), 1, a1, a3);
662 if (IC::ICUseVector(kind())) { 662 if (IC::ICUseVector(kind())) {
663 DiscardVectorAndSlot(); 663 DiscardVectorAndSlot();
664 } 664 }
665 __ Ret(USE_DELAY_SLOT); 665 __ Ret(USE_DELAY_SLOT);
666 __ mov(v0, result); 666 __ Move(v0, result); // Ensure the stub returns correct value.
667 667
668 FrontendFooter(name, &miss); 668 FrontendFooter(name, &miss);
669 669
670 // Return the generated code. 670 // Return the generated code.
671 return GetCode(kind(), name); 671 return GetCode(kind(), name);
672 } 672 }
673 673
674 674
675 #undef __ 675 #undef __
676 } // namespace internal 676 } // namespace internal
677 } // namespace v8 677 } // namespace v8
678 678
679 #endif // V8_TARGET_ARCH_MIPS64 679 #endif // V8_TARGET_ARCH_MIPS64
OLDNEW
« no previous file with comments | « src/ic/mips/ic-mips.cc ('k') | src/ic/mips64/ic-mips64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698