reflow comments in wtf/text

reflow comments in wtf/text

BUG=563793
Committed: https://crrev.com/26e2733660998f34f0998a56516c317fcaaa9359
Cr-Commit-Position: refs/heads/master@{#422321}

[Nico, 2016-10-01 02:47:47]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-01 02:48:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2016-10-01 02:48:03]

thakis@chromium.org changed reviewers:
+ dcheng@chromium.org

[dcheng, 2016-10-01 03:06:14]

lgtm

https://codereview.chromium.org/2373983006/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/wtf/text/Collator.h (right):

https://codereview.chromium.org/2373983006/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/wtf/text/Collator.h:54: Collator(const char* locale);
If we just add explicit here, will things still build?

https://codereview.chromium.org/2373983006/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/wtf/text/StringImplCF.cpp (right):

https://codereview.chromium.org/2373983006/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/wtf/text/StringImplCF.cpp:157: // StringImpl and just
return that.  But to do that we'd have to compute the
Out of curiosity, why are the spaces inconsistent between comments? There are
extra here, but no extra in StringUTF8Adaptor.h.

https://codereview.chromium.org/2373983006/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/wtf/text/TextCodecUTF16.cpp (left):

https://codereview.chromium.org/2373983006/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/wtf/text/TextCodecUTF16.cpp:175: // In the LChar case,
we do actually need to perform this check in release.  :)
Heh

[Nico, 2016-10-01 03:08:49]

The CQ bit was unchecked by thakis@chromium.org

[Nico, 2016-10-01 16:42:24]

thanks!

https://codereview.chromium.org/2373983006/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/wtf/text/Collator.h (right):

https://codereview.chromium.org/2373983006/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/wtf/text/Collator.h:54: Collator(const char* locale);
On 2016/10/01 03:06:14, dcheng wrote:
> If we just add explicit here, will things still build?

I don't know. I can try in a separate CL.

https://codereview.chromium.org/2373983006/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/wtf/text/StringImplCF.cpp (right):

https://codereview.chromium.org/2373983006/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/wtf/text/StringImplCF.cpp:157: // StringImpl and just
return that.  But to do that we'd have to compute the
On 2016/10/01 03:06:14, dcheng wrote:
> Out of curiosity, why are the spaces inconsistent between comments? There are
> extra here, but no extra in StringUTF8Adaptor.h.

I used vim's gq to reflow comments. The . was at end of line, so I guess my vim
config tells vim to keep the space in that case, but in the other file there was
no '.' at line end.

[Nico, 2016-10-01 16:42:31]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2016-10-01 16:42:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-01 16:48:02]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-01 16:49:58]

Description was changed from

==========
reflow comments in wtf/text

BUG=563793
==========

to

==========
reflow comments in wtf/text

BUG=563793

Committed: https://crrev.com/26e2733660998f34f0998a56516c317fcaaa9359
Cr-Commit-Position: refs/heads/master@{#422321}
==========

[commit-bot: I haz the power, 2016-10-01 16:49:59]

Patchset 1 (id:??) landed as
https://crrev.com/26e2733660998f34f0998a56516c317fcaaa9359
Cr-Commit-Position: refs/heads/master@{#422321}

[Nico, 2016-10-01 16:54:52]

https://codereview.chromium.org/2373983006/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/wtf/text/Collator.h (right):

https://codereview.chromium.org/2373983006/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/wtf/text/Collator.h:54: Collator(const char* locale);
On 2016/10/01 16:42:24, Nico (mostly away until Oct 3) wrote:
> On 2016/10/01 03:06:14, dcheng wrote:
> > If we just add explicit here, will things still build?
> 
> I don't know. I can try in a separate CL.

here: https://codereview.chromium.org/2383163003