Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 2383163003: Make collator ctor explicit. (Closed)

Created:
4 years, 2 months ago by Nico
Modified:
4 years, 2 months ago
Reviewers:
dcheng
CC:
chromium-reviews, blink-reviews, blink-reviews-wtf_chromium.org, Mikhail
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make collator ctor explicit. No behavior change. BUG= Committed: https://crrev.com/8708fded8484960c3358cf5a215dbf8179d2cd9a Cr-Commit-Position: refs/heads/master@{#422325}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/wtf/text/Collator.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (9 generated)
dcheng
Looks like the bots are OK with this.
4 years, 2 months ago (2016-10-01 17:43:13 UTC) #4
Nico
On 2016/10/01 17:43:13, dcheng wrote: > Looks like the bots are OK with this. Cool...wanna ...
4 years, 2 months ago (2016-10-01 18:23:48 UTC) #8
dcheng
LGTM
4 years, 2 months ago (2016-10-01 18:24:54 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2383163003/1
4 years, 2 months ago (2016-10-01 18:48:38 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-01 18:53:12 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-10-01 18:56:18 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8708fded8484960c3358cf5a215dbf8179d2cd9a
Cr-Commit-Position: refs/heads/master@{#422325}

Powered by Google App Engine
This is Rietveld 408576698