Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Unified Diff: tools/perf/page_sets/tough_ad_cases.py

Issue 2373983005: perf: Speculative fix for Swiffy WebGL ad pages (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/page_sets/tough_ad_cases.py
diff --git a/tools/perf/page_sets/tough_ad_cases.py b/tools/perf/page_sets/tough_ad_cases.py
index f076f6a4f5f2ef6fd9accbba9e543f5b248d6d20..68321d1062f08570107e608e017d9eb4ac6306f3 100644
--- a/tools/perf/page_sets/tough_ad_cases.py
+++ b/tools/perf/page_sets/tough_ad_cases.py
@@ -4,6 +4,7 @@
from page_sets import repeatable_synthesize_scroll_gesture_shared_state
+from telemetry.core import util
from telemetry.page import page as page_module
from telemetry import story
@@ -16,6 +17,8 @@ class SwiffyPage(page_module.Page):
def RunNavigateSteps(self, action_runner):
super(SwiffyPage, self).RunNavigateSteps(action_runner)
+ # Make sure the ad has finished loading.
+ util.WaitFor(action_runner.tab.HasReachedQuiescence, 60)
# Swiffy overwrites toString() to return a constant string, so "undo" that
# here so that we don't think it has stomped over console.time.
action_runner.EvaluateJavaScript(
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698