Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1724)

Unified Diff: components/offline_pages/background/request_coordinator.cc

Issue 2373933003: [Offline pages] Updating RequestQueue::RemoveRequests to use a TaskQueue (Closed)
Patch Set: Rebasing Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/background/request_coordinator.cc
diff --git a/components/offline_pages/background/request_coordinator.cc b/components/offline_pages/background/request_coordinator.cc
index 1138909ac2e1abee9de1c9f3e09ce1c09fdb807b..0cb161996851d3e0925be5e99ed2f7df3f624d80 100644
--- a/components/offline_pages/background/request_coordinator.cc
+++ b/components/offline_pages/background/request_coordinator.cc
@@ -314,18 +314,16 @@ void RequestCoordinator::UpdateMultipleRequestsCallback(
void RequestCoordinator::HandleRemovedRequestsAndCallback(
const RemoveRequestsCallback& callback,
BackgroundSavePageResult status,
- const RequestQueue::UpdateMultipleRequestResults& results,
- std::vector<std::unique_ptr<SavePageRequest>> requests) {
- callback.Run(results);
- HandleRemovedRequests(status, results, std::move(requests));
+ std::unique_ptr<UpdateRequestsResult> result) {
+ callback.Run(result->item_statuses);
+ HandleRemovedRequests(status, std::move(result));
}
void RequestCoordinator::HandleRemovedRequests(
BackgroundSavePageResult status,
- const RequestQueue::UpdateMultipleRequestResults& results,
- std::vector<std::unique_ptr<SavePageRequest>> requests) {
- for (const auto& request : requests)
- NotifyCompleted(*request, status);
+ std::unique_ptr<UpdateRequestsResult> result) {
+ for (const auto& request : result->updated_items)
+ NotifyCompleted(request, status);
}
void RequestCoordinator::ScheduleAsNeeded() {

Powered by Google App Engine
This is Rietveld 408576698