[Offline pages] Updating RequestQueue::RemoveRequests to use a TaskQueue

components/offline_pages/background/request_queue.h

Index: components/offline_pages/background/request_queue.h
diff --git a/components/offline_pages/background/request_queue.h b/components/offline_pages/background/request_queue.h
index 445a1f9a332b29e1fdcb7bd023f6f63e1f54e47e..170189bfc57e11d0d043b74d6d45b5d429aed3a8 100644
--- a/components/offline_pages/background/request_queue.h
+++ b/components/offline_pages/background/request_queue.h
@@ -48,10 +48,6 @@ class RequestQueue {
                              // exist.
   };
 
-  // Type for a pair of request_id and result.
-  typedef std::vector<std::pair<int64_t, UpdateRequestResult>>
-      UpdateMultipleRequestResults;
-
   // Callback used for |GetRequests|.
   typedef base::Callback<void(GetRequestsResult,
                               std::vector<std::unique_ptr<SavePageRequest>>)>
@@ -68,15 +64,9 @@ class RequestQueue {
   // Callback used by |UdpateRequest|.
   typedef base::Callback<void(UpdateRequestResult)> UpdateRequestCallback;
 
-  // Callback used by |ChangeState| for more than one update at a time.
-  typedef base::Callback<void(
-      const UpdateMultipleRequestResults& results,
-      std::vector<std::unique_ptr<SavePageRequest>> requests)>
-      UpdateMultipleRequestsCallback;
-
   // Callback used by |RemoveRequests|.
   typedef base::Callback<void(
-      const UpdateMultipleRequestResults& results,
+      const MultipleItemStatuses& results,
       std::vector<std::unique_ptr<SavePageRequest>> requests)>
       RemoveRequestsCallback;
 
@@ -105,6 +95,9 @@ class RequestQueue {
   void RemoveRequests(const std::vector<int64_t>& request_ids,
                       const RemoveRequestsCallback& callback);
 
+  void RemoveRequests(const std::vector<int64_t>& request_ids,

[Pete Williamson, 2016/09/30 18:03:53]

Why do we need two functions?

[Pete Williamson, 2016/09/30 18:03:53]

Why do we need two function declarations for RemoveRequests?  Can we get rid of
the other one?

[fgorski, 2016/10/04 17:18:23]

Done.

That was the plan. As you probably guessed, during development I had 2 functions
side by side to gently switch from one to the other.

+                      const UpdateCallback& callback);
+
   // Changes the state to |new_state| for requests matching the
   // |request_ids|. Results are returned through |callback|.
   void ChangeRequestsState(const std::vector<int64_t>& request_ids,