Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 2373933002: Call ContextLifecycleObserver::contextDestroyed() when a window object is reset (Closed)

Created:
4 years, 2 months ago by haraken
Modified:
4 years, 2 months ago
Reviewers:
dcheng
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Call ContextLifecycleObserver::contextDestroyed() when a window object is reset Currently, when a window object is reset, DOMWindowProperty::frameDestroyed() is called but ContextLifecycleObserver::contextDestroyed() is not called. This CL makes the latter get called as well. This is a preparation for replacing DOMWindowProperty with ContextLifecycleObsever. BUG=610176 Committed: https://crrev.com/4034fc1d8c67c3c6069c20047f55aee7b219e8cf Cr-Commit-Position: refs/heads/master@{#421690}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
haraken
PTAL
4 years, 2 months ago (2016-09-28 04:26:06 UTC) #8
dcheng
On 2016/09/28 04:26:06, haraken wrote: > PTAL LGTM. I feel like the naming of reset() ...
4 years, 2 months ago (2016-09-28 20:14:34 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2373933002/1
4 years, 2 months ago (2016-09-29 00:04:35 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-29 00:10:30 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 00:14:46 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4034fc1d8c67c3c6069c20047f55aee7b219e8cf
Cr-Commit-Position: refs/heads/master@{#421690}

Powered by Google App Engine
This is Rietveld 408576698