third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp - Issue 2373933002: Call ContextLifecycleObserver::contextDestroyed() when a window object is reset

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp

Issue 2373933002: Call ContextLifecycleObserver::contextDestroyed() when a window object is reset (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp

diff --git a/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp b/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp

index 3b8e896d6faae3b6c4a9425afaef82cf731e96e5..d9132e32eaee9cd2c2b420e05fb0b7a75bf81f26 100644

--- a/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp

+++ b/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp

@@ -487,6 +487,8 @@ void LocalDOMWindow::registerEventListenerObserver(EventListenerObserver* eventL

void LocalDOMWindow::reset()

{

+ DCHECK(document());

+ document()->notifyContextDestroyed();

frameDestroyed();

m_screen = nullptr;

« no previous file with comments | « no previous file | no next file » | no next file with comments »