Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(540)

Issue 2373873002: Merge "SELECT popup: Touch input should not be able to select disabled OPTIONs." to M54. (Closed)

Created:
4 years, 2 months ago by tkent
Modified:
4 years, 2 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Merge "SELECT popup: Touch input should not be able to select disabled OPTIONs." to M54. In a case of mouseup, we refer to event.target and mouse-related events are never dispatched on disabled OPTIONs. In a case of touch, we need to check disabled state manually because we don't use event.target. BUG=624302 Review-Url: https://codereview.chromium.org/2360483002 Cr-Commit-Position: refs/heads/master@{#419993} (cherry picked from commit cb2759d07dc61f89764c8e9d0e0984fec59733b8) Committed: https://chromium.googlesource.com/chromium/src/+/a365129389733cb105d15a5da4994fd3b5a00b94

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -3 lines) Patch
M third_party/WebKit/LayoutTests/fast/forms/select-popup/popup-menu-touch-operations.html View 1 chunk +34 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/select-popup/popup-menu-touch-operations-expected.txt View 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/resources/listPicker.js View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
tkent
4 years, 2 months ago (2016-09-27 21:19:27 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a365129389733cb105d15a5da4994fd3b5a00b94.

Powered by Google App Engine
This is Rietveld 408576698