Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issue 2360483002: SELECT popup: Touch input should not be able to select disabled OPTIONs. (Closed)

Created:
4 years, 3 months ago by tkent
Modified:
4 years, 3 months ago
Reviewers:
keishi
CC:
blink-reviews, chromium-reviews, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

SELECT popup: Touch input should not be able to select disabled OPTIONs. In a case of mouseup, we refer to event.target and mouse-related events are never dispatched on disabled OPTIONs. In a case of touch, we need to check disabled state manually because we don't use event.target. BUG=624302 Committed: https://crrev.com/cb2759d07dc61f89764c8e9d0e0984fec59733b8 Cr-Commit-Position: refs/heads/master@{#419993}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -3 lines) Patch
M third_party/WebKit/LayoutTests/fast/forms/select-popup/popup-menu-touch-operations.html View 1 chunk +34 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/select-popup/popup-menu-touch-operations-expected.txt View 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/resources/listPicker.js View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
tkent
keishi@, would you review this please?
4 years, 3 months ago (2016-09-21 05:11:02 UTC) #5
keishi
LGTM
4 years, 3 months ago (2016-09-21 05:34:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2360483002/1
4 years, 3 months ago (2016-09-21 06:43:09 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-21 07:15:59 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-21 07:18:05 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cb2759d07dc61f89764c8e9d0e0984fec59733b8
Cr-Commit-Position: refs/heads/master@{#419993}

Powered by Google App Engine
This is Rietveld 408576698