mustash: Connect ash system tray "show settings" items to chrome over mojo

mustash: Connect ash system tray "show settings" items to chrome over mojo

* Wire everything from SystemTrayDelegateMus -> ash::mojom::SystemTrayClient -> SystemTrayCommon
* Rename ChangeProxySettings to ShowProxySettings for consistency with other methods
* Eliminate SystemTrayDelegate::ShowSupervisedUserInfo - it has been unimplemented for 3 years
* Removed unused SystemTrayDelegate::ChangeProfilePicture and associated URL and UMA metric

While doing this I found a few items that will need to be refactored in chrome
before they can be wired up. I left TODOs for them rather than skipping them
because it will save me some work later.

BUG=647412
TEST=ash_unittests, manual testing of system tray menu in chrome --mash

Committed: https://crrev.com/9da5671dace9092f33d0c65a05162f9da5360d53
Cr-Commit-Position: refs/heads/master@{#421397}

[James Cook, 2016-09-27 19:42:54]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-27 19:43:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2016-09-27 19:46:14]

jamescook@chromium.org changed reviewers:
+ msw@chromium.org

[James Cook, 2016-09-27 19:46:15]

msw, please take a look.

https://codereview.chromium.org/2373863002/diff/1/chrome/browser/ui/ash/syste...
File chrome/browser/ui/ash/system_tray_common.h (right):

https://codereview.chromium.org/2373863002/diff/1/chrome/browser/ui/ash/syste...
chrome/browser/ui/ash/system_tray_common.h:14: class SystemTrayCommon {
While all the methods in this class are static right now, I'm anticipating it
will have member variables soon, which is why it's not just a namespace or set
of utility functions.

[msw, 2016-09-27 20:14:34]

lgtm with nits

https://codereview.chromium.org/2373863002/diff/1/ash/common/system/chromeos/...
File ash/common/system/chromeos/supervised/tray_supervised_user.cc (right):

https://codereview.chromium.org/2373863002/diff/1/ash/common/system/chromeos/...
ash/common/system/chromeos/supervised/tray_supervised_user.cc:72: //
TODO(antrim): find out what should we show in this case.
nit: cc antrim? remove/update bug citation (it's closed...)

https://codereview.chromium.org/2373863002/diff/1/ash/mus/system_tray_delegat...
File ash/mus/system_tray_delegate_mus.cc (right):

https://codereview.chromium.org/2373863002/diff/1/ash/mus/system_tray_delegat...
ash/mus/system_tray_delegate_mus.cc:62: ConnectToSystemTrayClient();
optional nit: make ConnectToSystemTrayClient return |system_tray_client_| (and
optionally rename it to GetSystemTrayClient), so you can just do:
GetSystemTrayClient()->ShowSettings() or
ConnectToSystemTrayClient->ShowSettings() and similar elsewhere below.

https://codereview.chromium.org/2373863002/diff/1/ash/mus/system_tray_delegat...
ash/mus/system_tray_delegate_mus.cc:63: system_tray_client_->ShowSettings();
nice! looking forward to using this myself

https://codereview.chromium.org/2373863002/diff/1/chrome/browser/ui/ash/syste...
File chrome/browser/ui/ash/system_tray_common.cc (right):

https://codereview.chromium.org/2373863002/diff/1/chrome/browser/ui/ash/syste...
chrome/browser/ui/ash/system_tray_common.cc:40:
ShowSettingsSubPageForActiveUser("");
nit: s/""/std::string()/

https://codereview.chromium.org/2373863002/diff/1/chrome/browser/ui/ash/syste...
File chrome/browser/ui/ash/system_tray_common.h (right):

https://codereview.chromium.org/2373863002/diff/1/chrome/browser/ui/ash/syste...
chrome/browser/ui/ash/system_tray_common.h:14: class SystemTrayCommon {
On 2016/09/27 19:46:15, James Cook wrote:
> While all the methods in this class are static right now, I'm anticipating it
> will have member variables soon, which is why it's not just a namespace or set
> of utility functions.

Acknowledged.

[James Cook, 2016-09-27 20:47:14]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-27 20:47:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2016-09-27 20:48:59]

Thanks for the quick review.

https://codereview.chromium.org/2373863002/diff/1/ash/common/system/chromeos/...
File ash/common/system/chromeos/supervised/tray_supervised_user.cc (right):

https://codereview.chromium.org/2373863002/diff/1/ash/common/system/chromeos/...
ash/common/system/chromeos/supervised/tray_supervised_user.cc:72: //
TODO(antrim): find out what should we show in this case.
On 2016/09/27 20:14:33, msw wrote:
> nit: cc antrim? remove/update bug citation (it's closed...)

Removed the bug number and pinged the bug + kuscher. antrim doesn't work on
chrome anymore.

https://codereview.chromium.org/2373863002/diff/1/ash/mus/system_tray_delegat...
File ash/mus/system_tray_delegate_mus.cc (right):

https://codereview.chromium.org/2373863002/diff/1/ash/mus/system_tray_delegat...
ash/mus/system_tray_delegate_mus.cc:62: ConnectToSystemTrayClient();
On 2016/09/27 20:14:33, msw wrote:
> optional nit: make ConnectToSystemTrayClient return |system_tray_client_| (and
> optionally rename it to GetSystemTrayClient), so you can just do:
> GetSystemTrayClient()->ShowSettings() or
> ConnectToSystemTrayClient->ShowSettings() and similar elsewhere below.

Done. I kept the name ConnectToSystemTrayClient() to emphasize the reconnecting
behavior.

https://codereview.chromium.org/2373863002/diff/1/chrome/browser/ui/ash/syste...
File chrome/browser/ui/ash/system_tray_common.cc (right):

https://codereview.chromium.org/2373863002/diff/1/chrome/browser/ui/ash/syste...
chrome/browser/ui/ash/system_tray_common.cc:40:
ShowSettingsSubPageForActiveUser("");
On 2016/09/27 20:14:34, msw wrote:
> nit: s/""/std::string()/

Done.

[James Cook, 2016-09-27 20:49:35]

jamescook@chromium.org changed reviewers:
+ isherman@chromium.org, tsepez@chromium.org

[James Cook, 2016-09-27 20:49:35]

tsepez, please take a look at //ash/public/interfaces/system_tray.mojom

isherman, can I get a rubber-stamp for deprecating an unused metric in
actions.xml?

[Tom Sepez, 2016-09-27 21:05:02]

mojom LGTM

[commit-bot: I haz the power, 2016-09-27 21:53:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 21:53:40]

Dry run: This issue passed the CQ dry run.

[Ilya Sherman, 2016-09-28 00:23:00]

actions.xml lgtm

[James Cook, 2016-09-28 00:27:21]

The CQ bit was checked by jamescook@chromium.org

[James Cook, 2016-09-28 00:27:22]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org
Link to the patchset: https://codereview.chromium.org/2373863002/#ps20001
(title: "review comments")

[commit-bot: I haz the power, 2016-09-28 00:27:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 00:35:12]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-28 00:39:27]

Description was changed from

==========
mustash: Connect ash system tray "show settings" items to chrome over mojo

* Wire everything from SystemTrayDelegateMus -> ash::mojom::SystemTrayClient ->
SystemTrayCommon
* Rename ChangeProxySettings to ShowProxySettings for consistency with other
methods
* Eliminate SystemTrayDelegate::ShowSupervisedUserInfo - it has been
unimplemented for 3 years
* Removed unused SystemTrayDelegate::ChangeProfilePicture and associated URL and
UMA metric

While doing this I found a few items that will need to be refactored in chrome
before they can be wired up. I left TODOs for them rather than skipping them
because it will save me some work later.

BUG=647412
TEST=ash_unittests, manual testing of system tray menu in chrome --mash
==========

to

==========
mustash: Connect ash system tray "show settings" items to chrome over mojo

* Wire everything from SystemTrayDelegateMus -> ash::mojom::SystemTrayClient ->
SystemTrayCommon
* Rename ChangeProxySettings to ShowProxySettings for consistency with other
methods
* Eliminate SystemTrayDelegate::ShowSupervisedUserInfo - it has been
unimplemented for 3 years
* Removed unused SystemTrayDelegate::ChangeProfilePicture and associated URL and
UMA metric

While doing this I found a few items that will need to be refactored in chrome
before they can be wired up. I left TODOs for them rather than skipping them
because it will save me some work later.

BUG=647412
TEST=ash_unittests, manual testing of system tray menu in chrome --mash

Committed: https://crrev.com/9da5671dace9092f33d0c65a05162f9da5360d53
Cr-Commit-Position: refs/heads/master@{#421397}
==========

[commit-bot: I haz the power, 2016-09-28 00:39:28]

Patchset 2 (id:??) landed as
https://crrev.com/9da5671dace9092f33d0c65a05162f9da5360d53
Cr-Commit-Position: refs/heads/master@{#421397}