mustash: Connect ash system tray "show settings" items to chrome over mojo

ash/mus/system_tray_delegate_mus.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/mus/system_tray_delegate_mus.h"
 
 #include "ash/common/system/tray/system_tray_notifier.h"
 #include "ash/common/wm_shell.h"
 #include "base/bind.h"
 #include "base/bind_helpers.h"
@@ skipping 33 matching lines @@
 
   // Tolerate chrome crashing and coming back up.
   system_tray_client_.set_connection_error_handler(base::Bind(
       &SystemTrayDelegateMus::OnClientConnectionError, base::Unretained(this)));
 }
 
 void SystemTrayDelegateMus::OnClientConnectionError() {
   system_tray_client_.reset();
 }
 
+////////////////////////////////////////////////////////////////////////////////
+// SystemTrayDelegate:
+
 base::HourClockType SystemTrayDelegateMus::GetHourClockType() const {
   return hour_clock_type_;
 }
 
+void SystemTrayDelegateMus::ShowSettings() {
+  ConnectToSystemTrayClient();

[msw, 2016/09/27 20:14:33]

optional nit: make ConnectToSystemTrayClient return |system_tray_client_| (and
optionally rename it to GetSystemTrayClient), so you can just do:
GetSystemTrayClient()->ShowSettings() or
ConnectToSystemTrayClient->ShowSettings() and similar elsewhere below.

[James Cook, 2016/09/27 20:48:59]

Done. I kept the name ConnectToSystemTrayClient() to emphasize the reconnecting
behavior.

+  system_tray_client_->ShowSettings();

[msw, 2016/09/27 20:14:34]

nice! looking forward to using this myself

+}
+
 void SystemTrayDelegateMus::ShowDateSettings() {
   ConnectToSystemTrayClient();
   system_tray_client_->ShowDateSettings();
 }
 
+void SystemTrayDelegateMus::ShowNetworkSettingsForGuid(
+    const std::string& guid) {
+  // http://crbug.com/647412
+  NOTIMPLEMENTED();
+}
+
+void SystemTrayDelegateMus::ShowDisplaySettings() {
+  ConnectToSystemTrayClient();
+  system_tray_client_->ShowDisplaySettings();
+}
+
+void SystemTrayDelegateMus::ShowPowerSettings() {
+  // http://crbug.com/647412
+  NOTIMPLEMENTED();
+}
+
+void SystemTrayDelegateMus::ShowChromeSlow() {
+  ConnectToSystemTrayClient();
+  system_tray_client_->ShowChromeSlow();
+}
+
+void SystemTrayDelegateMus::ShowIMESettings() {
+  ConnectToSystemTrayClient();
+  system_tray_client_->ShowIMESettings();
+}
+
+void SystemTrayDelegateMus::ShowHelp() {
+  ConnectToSystemTrayClient();
+  system_tray_client_->ShowHelp();
+}
+
+void SystemTrayDelegateMus::ShowAccessibilityHelp() {
+  ConnectToSystemTrayClient();
+  system_tray_client_->ShowAccessibilityHelp();
+}
+
+void SystemTrayDelegateMus::ShowAccessibilitySettings() {
+  ConnectToSystemTrayClient();
+  system_tray_client_->ShowAccessibilitySettings();
+}
+
+void SystemTrayDelegateMus::ShowPaletteHelp() {
+  ConnectToSystemTrayClient();
+  system_tray_client_->ShowPaletteHelp();
+}
+
+void SystemTrayDelegateMus::ShowPaletteSettings() {
+  ConnectToSystemTrayClient();
+  system_tray_client_->ShowPaletteSettings();
+}
+
+void SystemTrayDelegateMus::ShowPublicAccountInfo() {
+  ConnectToSystemTrayClient();
+  system_tray_client_->ShowPublicAccountInfo();
+}
+
+void SystemTrayDelegateMus::ShowEnterpriseInfo() {
+  // http://crbug.com/647412
+  NOTIMPLEMENTED();
+}
+
+void SystemTrayDelegateMus::ShowProxySettings() {
+  ConnectToSystemTrayClient();
+  system_tray_client_->ShowProxySettings();
+}
+
+////////////////////////////////////////////////////////////////////////////////
+// mojom::SystemTray:
+
 void SystemTrayDelegateMus::SetUse24HourClock(bool use_24_hour) {
   hour_clock_type_ = use_24_hour ? base::k24HourClock : base::k12HourClock;
   WmShell::Get()->system_tray_notifier()->NotifyDateFormatChanged();
 }
 
 }  // namespace ash