Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2373783002:
[build] Link V8 as component in static library builds (Closed)
|
Created:
4 years, 2 months ago by Michael Achenbach Modified:
4 years ago CC:
v8-reviews_googlegroups.com Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[build] Link V8 as component in static library builds
BUG=v8:5435
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_compile_dbg_ng;master.tryserver.chromium.android:android_clang_dbg_recipe
Committed: https://crrev.com/1f74f551d0dc7404e16a20811553bae558687e82
Cr-Commit-Position: refs/heads/master@{#41304}
Patch Set 1 #Patch Set 2 : Fix template #Patch Set 3 : updates #Patch Set 4 : Review #
Messages
Total messages: 29 (14 generated)
Description was changed from ========== [build] Link V8 as component in static library builds BUG= ========== to ========== [build] Link V8 as component in static library builds BUG=v8:5435 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_compile_dbg_ng;master.tryserver.chromium.android:android_clang_dbg_recipe ==========
The CQ bit was checked by machenbach@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...) v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...) v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/13545) v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...) v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...) v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...) v8_linux_mips64el_compile_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
The CQ bit was checked by machenbach@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
machenbach@chromium.org changed reviewers: + jgruber@chromium.org, jochen@chromium.org
PTAL
The CQ bit was unchecked by machenbach@chromium.org
lgtm
have you verified that it produces an .a file? if so, lgtm
On 2016/09/27 14:45:07, jochen (slow) wrote: > have you verified that it produces an .a file? if so, lgtm hmpf, doesn't produce one. I only get a libv8_base.a if I turn the v8_base source set into a component. But no libv8.a. Guess it's because it has no sources itself?
On 2016/09/27 at 15:27:54, machenbach wrote: > On 2016/09/27 14:45:07, jochen (slow) wrote: > > have you verified that it produces an .a file? if so, lgtm > > hmpf, doesn't produce one. I only get a libv8_base.a if I turn the v8_base source set into a component. But no libv8.a. Guess it's because it has no sources itself? hum, maybe ask on gn-dev?
On 2016/09/29 11:57:46, jochen (slow) wrote: > On 2016/09/27 at 15:27:54, machenbach wrote: > > On 2016/09/27 14:45:07, jochen (slow) wrote: > > > have you verified that it produces an .a file? if so, lgtm > > > > hmpf, doesn't produce one. I only get a libv8_base.a if I turn the v8_base > source set into a component. But no libv8.a. Guess it's because it has no > sources itself? > > hum, maybe ask on gn-dev? I think I worked in the wrong line. Compared it to gyp now, there was never a libv8.a. There's also only a libv8_base.a and libv8_libbase.a etc. This we get by switching all the sub source_sets to static libraries. Will update the patch...
On 2016/09/29 12:24:36, machenbach (slow) wrote: > On 2016/09/29 11:57:46, jochen (slow) wrote: > > On 2016/09/27 at 15:27:54, machenbach wrote: > > > On 2016/09/27 14:45:07, jochen (slow) wrote: > > > > have you verified that it produces an .a file? if so, lgtm > > > > > > hmpf, doesn't produce one. I only get a libv8_base.a if I turn the v8_base > > source set into a component. But no libv8.a. Guess it's because it has no > > sources itself? > > > > hum, maybe ask on gn-dev? > > I think I worked in the wrong line. Compared it to gyp now, there was never a > libv8.a. There's also only a libv8_base.a and libv8_libbase.a etc. This we get > by switching all the sub source_sets to static libraries. Will update the > patch... hmm - maybe not useful. Now I get libv8_base.a 31MB vs. in gyp 2MB.
PTAL at patch 3. With this we can conditionally get complete .a files in v8 standalone by setting gn args: component_build = false v8_component_build = true
why component() and not static_library()?
On 2016/11/28 09:40:36, jochen wrote: > why component() and not static_library()? Had the desired result. Lemme change it and see if it's the same.
On 2016/11/28 09:44:36, Michael Achenbach wrote: > On 2016/11/28 09:40:36, jochen wrote: > > why component() and not static_library()? > > Had the desired result. Lemme change it and see if it's the same. Seems to be equivalent internally. Change it as you suggested as it's the better name for the concept. Also changed the gn arg to v8_static_library.
lgtm
The CQ bit was checked by machenbach@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jgruber@chromium.org Link to the patchset: https://codereview.chromium.org/2373783002/#ps60001 (title: "Review")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1480326760569280,
"parent_rev": "c8acef2417d6a175def81c18b8ef4067d28d017b", "commit_rev":
"e06aa9dfe5f0528a009fd74f88aaa919ecb91dd7"}
Message was sent while issue was closed.
Description was changed from ========== [build] Link V8 as component in static library builds BUG=v8:5435 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_compile_dbg_ng;master.tryserver.chromium.android:android_clang_dbg_recipe ========== to ========== [build] Link V8 as component in static library builds BUG=v8:5435 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_compile_dbg_ng;master.tryserver.chromium.android:android_clang_dbg_recipe ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== [build] Link V8 as component in static library builds BUG=v8:5435 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_compile_dbg_ng;master.tryserver.chromium.android:android_clang_dbg_recipe ========== to ========== [build] Link V8 as component in static library builds BUG=v8:5435 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_compile_dbg_ng;master.tryserver.chromium.android:android_clang_dbg_recipe Committed: https://crrev.com/1f74f551d0dc7404e16a20811553bae558687e82 Cr-Commit-Position: refs/heads/master@{#41304} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/1f74f551d0dc7404e16a20811553bae558687e82 Cr-Commit-Position: refs/heads/master@{#41304} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
